-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixes for using system packages #7177
base: main
Are you sure you want to change the base?
Conversation
Thanks for submitting this pull request! The maintainers of this repository would appreciate if you could update the CHANGELOG.md based on your changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @christian-rauch for these fixes! Please see one comment below.
|
||
if(NOT USE_SYSTEM_CURL) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @christian-rauch we need SSL as an indirect dependency of cURL. So with USE_SYSTEM_CURL, we do not expliclty need to find and link system SSL. Can you update this so that SSL is ignored with USE_SYSTEM_CURL?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But isn't this exactly what the commit is fixing? Previously, with USE_SYSTEM_CURL
set to ON
, we would not link SSL. Hence, the linking issues. So with USE_SYSTEM_CURL=ON
, we still need to link SSL explicitly.
Btw, |
I was building Open3D with most system packages enabled and some features deactivated. This uncovered a couple of compilation and linking issues, such as:
ExtractZIP
whenWITH_MINIZIP
is offUSE_SYSTEM_CURL
andUSE_SYSTEM_OPENSSL
are setType
Motivation and Context
Fixing the build
Checklist:
python util/check_style.py --apply
to apply Open3D code styleto my code.
updated accordingly.
results (e.g. screenshots or numbers) here.
Description