Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Do not merge] gaussian rendering application #7187

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[Do not merge] gaussian rendering application #7187

wants to merge 1 commit into from

Conversation

zhangyang-intel
Copy link

Type

  • Bug fix (non-breaking change which fixes an issue): Fixes #
  • New feature (non-breaking change which adds functionality). Resolves #
  • Breaking change (fix or feature that would cause existing functionality to not work as expected) Resolves #

Motivation and Context

Checklist:

  • I have run python util/check_style.py --apply to apply Open3D code style
    to my code.
  • This PR changes Open3D behavior or adds new functionality.
    • Both C++ (Doxygen) and Python (Sphinx / Google style) documentation is
      updated accordingly.
    • I have added or updated C++ and / or Python unit tests OR included test
      results       (e.g. screenshots or numbers) here.
  • I will follow up and update the code if CI fails.
  • For fork PRs, I have selected Allow edits from maintainers.

Description

@update-docs Update Docs
Copy link

update-docs bot commented Mar 6, 2025

Thanks for submitting this pull request! The maintainers of this repository would appreciate if you could update the CHANGELOG.md based on your changes.

ssheorey
ssheorey reviewed Mar 7, 2025
View reviewed changes
Copy link
Member

@ssheorey ssheorey left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a good place to mention the limitations of the current implementation (as a comment): This will show the 3DGS as a point cloud with colors.
Suggested file name: DrawGaussianSplat.cpp

examples/cpp/GaussianRendering.cpp

using namespace open3d;

double GetRandom() { return double(std::rand()) / double(RAND_MAX); }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unused.

examples/cpp/GaussianRendering.cpp

void SingleObject() {
std::string file = "/home/zy/ws/Open3D/pointcloud/converted_point_cloud_29999_only_table.npz";
std::shared_ptr<t::geometry::PointCloud> pointcloud = std::make_shared<t::geometry::PointCloud>();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shared_ptr is unnecessary - we can just instantiate directly:
t::geometry::PointCloud pointcloud;

examples/cpp/GaussianRendering.cpp
std::string file = "/home/zy/ws/Open3D/pointcloud/converted_point_cloud_29999_only_table.npz";
std::shared_ptr<t::geometry::PointCloud> pointcloud = std::make_shared<t::geometry::PointCloud>();

io::ReadPointCloudOption tmp = io::ReadPointCloudOption();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unused?

@ssheorey ssheorey changed the title gaussian rendering application [Do not merge] gaussian rendering application Mar 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ssheorey ssheorey ssheorey left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
hackathon
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zhangyang-intel @ssheorey