Skip to content

Migrate storage version of networking APIs to v1 #3498

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Migrate storage version of networking APIs to v1 #3498

wants to merge 4 commits into from
+51 −42

Conversation

kfaseela
Copy link
Member

@kfaseela
Migrate storage version of networking APIs to v1
03e9de9 
Signed-off-by: Faseela K <faseela.k@est.tech>
@kfaseela kfaseela requested a review from a team as a code owner April 28, 2025 21:04
@istio-policy-bot
Copy link

🤔 🐛 You appear to be fixing a bug in Go code, yet your PR doesn't include updates to any test files. Did you forget to add a test?

Courtesy of your friendly test nag.

@istio-policy-bot
Copy link

😊 Welcome @kfaseela! This is either your first contribution to the Istio api repo, or it's been
a while since you've been here.

You can learn more about the Istio working groups, Code of Conduct, and contribution guidelines
by referring to Contributing to Istio.

Thanks for contributing!

Courtesy of your friendly welcome wagon.

@istio-testing istio-testing added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 28, 2025
@kfaseela kfaseela added the release-notes-none Indicates a PR that does not require release notes. label Apr 28, 2025
@kfaseela
Copy link
Member Author

@keithmattix : wondering why make gen did not set storageVersion: true for these CRDs in crd.gen.yaml

@kfaseela
add release notes
ef8275d 
Signed-off-by: Faseela K <faseela.k@est.tech>
@istio-testing istio-testing added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 28, 2025
@keithmattix
Copy link
Contributor

Hmm looks like this doesn't work the way I remember it working. Will take a look

@keithmattix
Copy link
Contributor

Ah, I remember now @kfaseela. We need to manually edit the versions that we need to make the storage version. So e.g. nothing under v1alpha3 should have storage version; remove that and manually add the comment to the v1 copies

kfaseela added 2 commits April 28, 2025 23:24
@kfaseela
fix release notes
a6d8213 
Signed-off-by: Faseela K <faseela.k@est.tech>
@kfaseela
generate crds
7c9b6a2 
Signed-off-by: Faseela K <faseela.k@est.tech>
@kfaseela kfaseela added the do-not-merge Block automatic merging of a PR. label Apr 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
do-not-merge Block automatic merging of a PR. release-notes-none Indicates a PR that does not require release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Migrate storage version for the Istio CRDs to v1
4 participants
@kfaseela @istio-policy-bot @keithmattix @istio-testing