Update section 2 with several additions for review #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Renumber spec lists a bit to get unique numbers and allow for insert additional specifications a bit more easily. - Collapse original section 2 "Formal specifications" into its main "Lexical specifications" to include lines, whitespace, etc. - Add Patrick Fasano comments on multiple whitespace characters (but be explicit about it being in non-character-constant contexts). - Remove the over-specified list of tokens. This is more appropriate for a syntax paper. Introduce tokens enough to allow us to use them in illustrative syntax. (We can remove the explicitness about the tokens ID, WHOLE_NUMBER, REAL_NUMBER, CHARACTER_STRING, and UNRECOGNIZED_TOKEN if we like.)
sblionel
approved these changes
Mar 29, 2025
kc9jud
approved these changes
Mar 29, 2025
JonSteidel
approved these changes
Mar 29, 2025
bonachea
requested changes
Mar 31, 2025
There was a problem hiding this comment.
Thanks for the continuing work on this!
I added several comments that I'd like to see resolved in the near-term.
A few of my comments (those regarding existing text) are somewhat orthogonal to this PR, and those could potentially be moved to the issue tracker if you'd rather handle them outside the scope of this PR.
drafts/25-xxx-specifications.txt
Outdated
Comment on lines
179
to
180
| to03. Without naming them all explicitly, they appear in the illustrative | ||
| syntax in subsequent sections. |
There was a problem hiding this comment.
Unclear what "them" and "they" refer to here.
I think we generally want each rule to stand-alone grammatically, and possibly refer explicitly to other rules when necessary.
Co-authored-by: Dan Bonachea <dobonachea@lbl.gov>
Co-authored-by: Dan Bonachea <dobonachea@lbl.gov>
Co-authored-by: Dan Bonachea <dobonachea@lbl.gov>
Co-authored-by: Dan Bonachea <dobonachea@lbl.gov>
We want to avoid using the term "execution" when referring to the translation and evaluation the preprocessor performs. Co-authored-by: Dan Bonachea <dobonachea@lbl.gov>
Co-authored-by: Dan Bonachea <dobonachea@lbl.gov>
bonachea
reviewed
Apr 1, 2025
- Add the term "C 2023" to the C standard working draft reference at the beginning. The WD calls it C 2023, and that's the term we use in this document. (It wasn't officially published until 2024.) - Move "to05" about whitespace in directive "names" to the section about whitespace (ws02), and explicitly reference that whitespace may precede or follow the '#' character. - Allow a more expansive view of the tokens accepted in object and function-like macros. (I didn't go so far as to say "anything goes that's not a newline" yet.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Renumber spec lists a bit to get unique numbers and allow for insert additional specifications a bit more easily.
Collapse original section 2 "Formal specifications" into its main "Lexical specifications" to include lines, whitespace, etc.
Add Patrick Fasano comments on multiple whitespace characters (but be explicit about it being in non-character-constant contexts).
Remove the over-specified list of tokens. This is more appropriate for a syntax paper. Introduce tokens enough to allow us to use them in illustrative syntax. (We can remove the explicitness about the tokens
ID,WHOLE_NUMBER,REAL_NUMBER,CHARACTER_STRING, andUNRECOGNIZED_TOKENif we like.)