Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken uri encoding in mopidy calls in 3.56 #711

Closed
2e0byo opened this issue Mar 6, 2021 · 1 comment
Closed

Broken uri encoding in mopidy calls in 3.56 #711

2e0byo opened this issue Mar 6, 2021 · 1 comment
Labels

Comments

@2e0byo
Copy link

2e0byo commented Mar 6, 2021

Describe the bug
3.56 breaks URI encoding for unicode tracks.

To Reproduce
Steps to reproduce the behavior:

  1. Enable Test Mode (Settings > Debug > Test Mode). This provides more verbose error logs.
  2. Select a track with unicode chars in the uri.
  3. Add to queue.
  4. Track is not added.
  5. Select 'play'.
  6. Iris notices it failed to enqueue the track.

Expected behavior
Track is enqueued.

Console log
from MOPIDY_ENQUEUE_URIS

With 3.55.4 the uri is:
"local:track:Non-Album/St%C3%A9phane%20Golmann/Actualit%C3%A9s.m4a"

With 3.56.1 the uri is:
"local:track:Non-Album/Stéphane%20Golmann/Actualités.m4a"

Environment details:

  • OS: Linux (various)
  • Browser: Qutebrowser
  • Iris version: 3.56.1/3.55.4

Additional context

Apologies to take so long to test 3.56 after it closed #601. #601 is only partially resolved; I've commented over there.

Really sorry not to offer anything more constructive than a bug report! I'm drowning in other code atm. Will have a look at this if I get a chance.

@2e0byo 2e0byo added the bug label Mar 6, 2021
@orontee
Copy link
Contributor

orontee commented Mar 14, 2021

Same problem here.

With mpc the following works well:

matthias@carbon:~ 
↳ mpc add local:track:Serge%20Gainsbourg/L%27Homme%20%C3%80%20T%C3%AAte%20De%20Chou%20%5BInt%C3%A9grale%2020%C3%A8me%20Anniversaire%5D/04%20Transit%20%C3%A0%20Marilou.flac

When I try to play the same song from the Local panel in Iris, I see the following message in /mopidy/ws/:

{"method":"core.tracklist.add","params":{"uris":["local:track:Serge%20Gainsbourg/L%27Homme%20�%20Tête%20De%20Chou%20%5BIntégrale%2020ème%20Anniversaire%5D/04%20Transit%20à %20Marilou.flac"],"at_position":0},"jsonrpc":"2.0","id":14}

and the response is (edited after I noticed a copy-paste error when writing that message, sorry):

{"jsonrpc": "2.0", "id": 14, "result": []}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants