Support Apollo Engine client awareness

[tw0517tw]

https://www.apollographql.com/docs/platform/client-awareness.html#Setup

Supports getting name and version from ApolloClient config.

[jaydenseric]

Sorry for the delay! I hope to review this in the next few days, in principle I support the change :)

[KillerCodeMonkey]

@jaydenseric is it possible to look into it again?

The failing test is only the file size limit.

Actually we can not distinguish our clients, because all clients are tracked by "Unidentified clients" in apollo engine and we can not get the important info like where an failing query comes from.

[StefanFeederle]

There is a workaround:

const httpLink = createUploadLink({
   uri: myUrl,
   headers: {
      'apollographql-client-name': myAppName,
      'apollographql-client-version': myAppVersion,
   },
});

[KillerCodeMonkey]

@StefanFeederle yes i know, sure. But if the ApolloClient provides the ability to set these options during client creation a link should pass through these options and do not break default apollo behavior. Thats why i am asking :)

Because if you are working in a big project in a team you do not want that everybody needs to know the workarounds. And instead of forking and creating x-custom modules it is better to solve those issues in the base repo if it is maintained. :)

Thanks for the response.

[jaydenseric]

Could someone who uses Apollo Engine please verify that this works ok?

npm install tw0517tw/apollo-upload-client#patch-3

Once verified, I'll publish the new version 🙏

[KillerCodeMonkey]

Nice. Maybe i can Test it this evening or tomorrow morning. Jayden Seric <notifications@github.com> schrieb am So., 7. Juli 2019, 08:34:

…

***@***.**** approved this pull request. Could someone who uses Apollo Engine please verify that this works ok? npm install tw0517tw/apollo-upload-client#patch-3 Once verified, I'll publish the new version 🙏 — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#143?email_source=notifications&email_token=AARI4YHHVHF243XDBQC7GE3P6GE6ZA5CNFSM4GTW6SF2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOB5VBSVY#pullrequestreview-258611543>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AARI4YERJTILMEZ5JQVEHZLP6GE6ZANCNFSM4GTW6SFQ> .

[KillerCodeMonkey]

seems to work 👍