Add support for Java 18 to 21 (fixes #52) #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olim7t
commented
Feb 28, 2025
| assertEquals(queueShallowSize + lockSize, meterIgnoring.measureDeep(queue)); | ||
| // The queue contains one reference that isn't strong (so ignored), so it should measure the | ||
| // same as an empty queue. | ||
| assertEquals(meterIgnoring.measureDeep(new ReferenceQueue<>()), meterIgnoring.measureDeep(queue)); |
There was a problem hiding this comment.
In earlier versions, ReferenceQueue uses a custom lock object internally. In newer versions, it uses a ReentrantLock and a Condition.
I think this achieves the same goal without the need to introduce complex conditional branches.
|
This overlaps with some of the work done in #71. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested on MacOS with Oracle versions 18.0.2.1, 19.0.2, 20.0.2 and 21.0.5 (arm64).
This only fixes issues that were detected by existing tests.