Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support watch which re-run tests when files changed #472

Merged
merged 5 commits into from
Sep 10, 2015
Merged

Support watch which re-run tests when files changed #472

merged 5 commits into from
Sep 10, 2015

Conversation

huang47
Copy link

@huang47 huang47 commented Aug 23, 2015

steal @amasad's wisdom from #96

I am still debugging why the default file watcher of sane emit duplicate events every time I make a file change.

@huang47
Copy link
Author

huang47 commented Aug 24, 2015

seems like a regression of nodejs/node-v0.x-archive#2126
by using watchman there is no such issue

@@ -4,6 +4,7 @@
"version": "0.5.0",
"main": "src/jest.js",
"dependencies": {
"bluebird": "^2.9.30",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why did you add this back? :)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

npm i --save which order the dependencies alphabetically.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

got it, please remove Bluebird – we are not using it any more :)

@amasad amasad merged commit 4aa1855 into jestjs:master Sep 10, 2015
@amasad
Copy link
Contributor

amasad commented Sep 10, 2015

@huang47 perfect! Followups:

  • Can we add this to the documentation/website?
  • Future improvements: only run the tests that was affected by the change
  • It'd be great, if we can do the same thing for internal jest test runner.

@amasad
Copy link
Contributor

amasad commented Sep 10, 2015

@cpojer should we release a new minor version for this?

@cpojer
Copy link
Member

cpojer commented Sep 10, 2015

Before publishing this I'd like to add documentation first. @huang47 can you send a pull request for that? :) I think a patch release is fine, based on how we develop jest we have only bumped "minor" versions for breaking changes.

We can also just go back to 5.0.4 and use semver properly, I wouldn't be opposed to that actually – let's discuss internally.

@huang47
Copy link
Author

huang47 commented Sep 11, 2015

sure, will create another PR to address the document changes.

@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants