-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support watch which re-run tests when files changed #472
Conversation
seems like a regression of nodejs/node-v0.x-archive#2126 |
@@ -4,6 +4,7 @@ | |||
"version": "0.5.0", | |||
"main": "src/jest.js", | |||
"dependencies": { | |||
"bluebird": "^2.9.30", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why did you add this back? :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
npm i --save
which order the dependencies alphabetically.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
got it, please remove Bluebird – we are not using it any more :)
@huang47 perfect! Followups:
|
@cpojer should we release a new minor version for this? |
Before publishing this I'd like to add documentation first. @huang47 can you send a pull request for that? :) I think a patch release is fine, based on how we develop jest we have only bumped "minor" versions for breaking changes. We can also just go back to 5.0.4 and use semver properly, I wouldn't be opposed to that actually – let's discuss internally. |
sure, will create another PR to address the document changes. |
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
steal @amasad's wisdom from #96
I am still debugging why the default file watcher of sane emit duplicate events every time I make a file change.