Support custom config.testRunner setting in normalizeConfig #531
Conversation
|
@facebook-github-bot import |
|
Thanks for importing. If you are an FB employee go to https://our.intern.facebook.com/intern/opensource/github/pull_request/923645757710017/int_phab to review. |
|
@facebook-github-bot shipit |
|
Thanks for importing. If you are an FB employee go to https://our.intern.facebook.com/intern/opensource/github/pull_request/923645757710017/int_phab to review. |
ghost
closed this
in
|
I used this pull request as a test for our FB sync infra. Now we can develop jest more efficiently at FB :) |
|
Cool. So I see this change is in master now, but the PR isn't shown as 'merged', as the commit sha is different. Perhaps it's worth having the bot post a comment on the PR making it clear the change was merged? Might make it easier for other people looking at closed PRs to figure out what the outcome was. |
|
Yeah we can't use the merge-feature on GitHub any more but right before my previous comment the bot has commented with a link to the diff that got merged. Is this what you mean? |
|
Hmm, yeah I was just suggesting the the bot could make an explicit comment on this PR so that, for others looking at this PR at a later date, it's clearer what the resolution was. Even to me it wasn't immediately obvious what the outcome was, as in Github terminology a PR being 'closed' is usually considered synonymous with 'rejected'. Perhaps an explicit comment on the PR might make things clearer for others? |
|
cc @vjeux ^ |
|
It says: "facebook-github-bot-4 closed this pull request from a commit 2 hours ago" where b93d00d is the sha of the closed version and facebook-github-bot as the name. People also receive an email saying it was closed.
I'm reluctant to have the bot comment because it's going to send another email to everyone in the thread and be spammy :x I'm not really sure how to better educate people saying that it was merged. |
|
Fair enough, perhaps the extra comment isn't the right answer, I just wanted to point out a potential point of confusion. |
|
Yeah thanks for that. If you have ideas on how to make it clearer, that would be awesome |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Adds
testRunnerto the list of config options which are pulled in from custom configuration, allowing custom test runner implementations to be used.