Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace node-worker-pool with node-worker-farm #540

Merged
merged 5 commits into from
Oct 7, 2015
Merged

Conversation

amasad
Copy link
Contributor

@amasad amasad commented Oct 6, 2015

  • More reliable (uses IPC instead of stdin/out)
  • No more weird messaging issues (unable to parse, message order, etc)
  • Allows (currently, up to 2) initialization errors per worker
  • Console logs can appear as they are executed (not buffered)
  • Also means that they console logs appear even when there is initialization errors
  • Simplifies console and logger implementation
  • Easier for debugging (even if the program crashes you can still see your logs)
  • Opens up opportunities for future more involved inter-worker communication (say sharing mocking work)
    cc @cpojer @DmitrySoshnikov

@amasad
Copy link
Contributor Author

amasad commented Oct 6, 2015

Potential issues to close:
#259
#539
#369
#341

@DmitrySoshnikov
Copy link
Contributor

Perfect, thanks!

@cpojer
Copy link
Member

cpojer commented Oct 7, 2015

wow this is awesome. I thought this was going to be a much more involved change, glad it allowed to get rid of a bit of code! Nice work @amasad.

@Pajn
Copy link
Contributor

Pajn commented Oct 13, 2015

When will this get published?

#259 shows up a lot in Travis so would be great to have this fix.
Maybe publish a prerelease so we can use this by explicitly requesting it but when just installing people will get the current version?

@cpojer
Copy link
Member

cpojer commented Oct 13, 2015

Soon @Pajn. Either this week or next week. We won't be doing a pre-release for 0.6.0.

@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants