Make development easier! #34
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfly
approved these changes
Oct 30, 2024
Nix shells are neat, thanks @jfly! We stole a page from mycli on how to run this entry point / script without having to pip install it. Due to this, we just happened to notice a latent bug with this __version__ variable because we only get a version when it's installed.
FatBoyXPC
force-pushed
the
add-nix-devshell
branch
from
ed15781 to
555a07c
Compare
Our nix build of shtuff was failing because it ran shtuff in a sandbox that didn't have shtuff installed. We used to pip install it in the Makefile but we opted out of doing that as it's unnecessary for Nix :) Due to getting rid of the venv, we needed to invoke shtuff a bit differently in the tests. That led to some interesting behavior. As we no longer have access to `shtuff` (as it's not pip installed), this meant the recursive `shtuff as` no longer works. Fixing this means we no longer get two prompts (yay positive side effect!) which explains the removal of the duplicate prompt assertion from some tests. While we were debugging this, we made a few tests improvements. One of these was moving from os.system() to subprocess.run() as os.system() ignores the exit code, which made the test wait to timeout when looking for output, as opposed to failing the test immediately. We also moved from capture_output (which captures both stdout _and_ stderr) to only capturing stdout, which allows us to see the stderr when debugging test failures.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nix shells are neat, thanks @jfly!
We stole a page from mycli on how to run this entry point / script without having to pip install it.
Due to this, we just happened to notice a latent bug with this version variable because we only get a version when it's installed.