Fix presence detection of libcxx.h #51
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
polter-rnd
force-pushed
the
fix-cxxabi-detection
branch
from
d2308f3 to
818c40c
Compare
We should check libcxx.h is present instead of just checking the compiler. Because on Windows using clang compiler this file is not present and the compilation fails.
polter-rnd
force-pushed
the
fix-cxxabi-detection
branch
from
818c40c to
f6c40b7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should check libcxx.h is present instead of just checking the compiler.
Because on Windows using clang compiler this file is not present and the compilation fails.
Since mettle already requires C++20, using
__has_includefeature seems to be the most accurate way of detecting this.