Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed lobby chat emoji react #15731

Merged
merged 4 commits into from
Mar 12, 2025
Merged

Conversation

laky241
Copy link
Contributor

@laky241 laky241 commented Mar 8, 2025

fixed this issue below--

Recording.2025-03-08.125526.mp4

after fix --

Recording.2025-03-08.135925.mp4

this issue is only in lobby chat

@jitsi-jenkins
Copy link

Hi, thanks for your contribution!
If you haven't already done so, could you please make sure you sign our CLA (https://jitsi.org/icla for individuals and https://jitsi.org/ccla for corporations)? We would unfortunately be unable to merge your patch unless we have that piece :(.

@damencho
Copy link
Member

damencho commented Mar 9, 2025

I don't think these reactions work at all when it comes to lobby chat messages. So, I think we should just disable the option to react to this type of message.

@damencho
Copy link
Member

damencho commented Mar 9, 2025

They are already disabled to private messages. The lobby messages are like private messages anyway.

@damencho
Copy link
Member

damencho commented Mar 9, 2025

And when creating PRs please avoid unecessary changes like formatting and whitespace. You have few tabs in this PR. Thank you.

@laky241
Copy link
Contributor Author

laky241 commented Mar 12, 2025

@damencho i have completely disabled the message reaction of lobby chat

Screenshot 2025-03-12 224917

@damencho
Copy link
Member

Jenkins test this please.

@damencho
Copy link
Member

Unrelated failure.

@damencho damencho merged commit e9236fd into jitsi:master Mar 12, 2025
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants