Skip to content

Fix/event browser html #1193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

danhemerlein
Copy link
Contributor

This updates some classNames to use a string (no need for {} if no dynamic logic)
If we're not using dynamic logic or variables, just pass the string directly

This also moves the EventsBrowser to a directory in DataView. I did this so I could move some types into their own file. I would like do another push of cleaning up this file (breaking it into smaller components)

Thank you!

@danhemerlein danhemerlein force-pushed the fix/event-browser-html branch from 28ba0d6 to e179090 Compare April 14, 2025 21:56
@danhemerlein danhemerlein force-pushed the fix/event-browser-html branch from e179090 to 15d66d6 Compare April 17, 2025 15:03
@vklimontovich
Copy link
Contributor

Although this PR totally make sense, we generally hesitant of making cosmetic changes and moving files around without strong reason to do so in scope of adding new features.

Speaking of classNames, that would make sense if we could add a prettier/linter rule to enforce that.

Looks like react/jsx-curly-brace-presence does exactly this, I'll try to add via separate commit

@danhemerlein
Copy link
Contributor Author

Although this PR totally make sense, we generally hesitant of making cosmetic changes and moving files around without strong reason to do so in scope of adding new features.

Speaking of classNames, that would make sense if we could add a prettier/linter rule to enforce that.

Looks like react/jsx-curly-brace-presence does exactly this, I'll try to add via separate commit

All good thank you very much for the review @vklimontovich please feel free to close this out if it doesn't make sense. Happy to help out with new feature development - especially if it's console app related. thanks!

@vklimontovich
Copy link
Contributor

Here's the change: ccbc8bf

We will swap it from warn to error once all PRs are merged to avoid merge conflicts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants