Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cli: fix running multiple test files #63

Merged
merged 1 commit into from
Mar 5, 2025

Conversation

pushcx
Copy link
Contributor

@pushcx pushcx commented Mar 1, 2025

Running be qt test/1.test.rb test/2.test.rb silently ignored all files after the first one. Dir.glob accepts an array, so this is an easy fix.

I dislike the temporal coupling of parse_options and parse_args caused by OptionParser mutating its inputs, but I saw it as a separate issue.

@joeldrapper joeldrapper merged commit 533d738 into joeldrapper:main Mar 5, 2025
10 of 11 checks passed
@willcosgrove
Copy link
Contributor

I think this is broken when you run qt with no arguments, because the @args array is empty but truthy, so the default value of "./**/*.test.rb" never gets used.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants