Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "[ruby] Ignore "Throwaway" AST Structures (#4982)" #4983

Merged
merged 1 commit into from
Oct 1, 2024
Merged

Revert "[ruby] Ignore "Throwaway" AST Structures (#4982)" #4983

merged 1 commit into from
Oct 1, 2024

Conversation

DavidBakerEffendi
Copy link
Collaborator

This reverts commit 3c27bf6.

This PR introduced a bug causing invalid CDGs around the type references.

@DavidBakerEffendi DavidBakerEffendi added the ruby Relates to rubysrc2cpg label Oct 1, 2024
@DavidBakerEffendi DavidBakerEffendi self-assigned this Oct 1, 2024
@DavidBakerEffendi DavidBakerEffendi merged commit 464480d into master Oct 1, 2024
5 checks passed
@max-leuthaeuser max-leuthaeuser deleted the dave/ruby/revert-typeref-fix branch October 1, 2024 18:54
DavidBakerEffendi added a commit that referenced this pull request Oct 2, 2024
@DavidBakerEffendi
Revert "Revert "[ruby] Ignore "Throwaway" AST Structures (#4982)" (#4983
8df04c0 
)"

This reverts commit 464480d.
DavidBakerEffendi added a commit that referenced this pull request Oct 2, 2024
@DavidBakerEffendi
[ruby] Re-implemented "Ignore "Throwaway" AST Structures (#4982)" (#4985
115e65c 
)

* Revert "Revert "[ruby] Ignore "Throwaway" AST Structures (#4982)" (#4983)"

This reverts commit 464480d.

* [ruby] Re-implemented "Ignore "Throwaway" AST Structures (#4982)"
This correctly prevents re-use of nodes that are already being used elsewhere by ensuring deep copies.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@max-leuthaeuser max-leuthaeuser max-leuthaeuser approved these changes

@AndreiDreyer AndreiDreyer Awaiting requested review from AndreiDreyer

Assignees

@DavidBakerEffendi DavidBakerEffendi

Labels
ruby Relates to rubysrc2cpg
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DavidBakerEffendi @max-leuthaeuser