Enhance What is new's style #507
Closed
+79
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Muhammad-Noraeii
commented
Mar 19, 2025
Muhammad-Noraeii
commented
- Split font shorthand into separate properties for better readability
- Added fallback system fonts for broader compatibility
- Simplified rem calculation while maintaining original size
- Changed background-color to full hex for consistency
- Improved code formatting with consistent spacing
- Split font shorthand into separate properties for better readability - Added fallback system fonts for broader compatibility - Simplified rem calculation while maintaining original size - Changed background-color to full hex for consistency - Improved code formatting with consistent spacing
Muhammad-Noraeii
changed the title
- Organized link states with consistent formatting - Maintained original color using HSL for better color management - Added smooth color transition on interaction - Included hover state with lighter shade for visual feedback - Added focus state with outline for keyboard accessibility - Kept background transparent and text-decoration none as per original
- Maintained specific [href] selector for targeted styling - Kept original dark blue hover color in HSL format - Enhanced underline with thickness and offset controls - Added smooth transition for all properties - Improved visual hierarchy with subtle spacing adjustments
- Replaced font shorthand with separate properties for clarity - Added specific monospace font stack with fallbacks - Simplified rem calculations for font-size and line-height - Converted pixel padding to rem for better scaling - Added white-space: pre-wrap for improved text wrapping - Maintained original color scheme and subtle background - Standardized border-radius to rem units
- Replaced 'normal' line-height with explicit 1.5 value - Added overflow-x: auto for horizontal scrolling of long lines - Included tab-size for consistent code indentation - Maintained original padding and border-radius intent
- Consolidated margin-top and margin-bottom into margin-block
- Changed color to full hex #ffffff for consistency - Replaced 'bold' with numeric font-weight 700 - Updated line-height from 'normal' to explicit 1.5 - Maintained original centered text and blue background - Improved formatting for better readability
- Converted 'bold' to font-weight 700 - Maintained original sizes - Improved consistency and readability
|
@martijnlaan |
|
Please make seperate pull requests as requested before. Please don't do any changes that make reviewing more difficult so for example do not change spacing. Please include detailed motivations for each change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.