Match OpenSSL::X509::Name.hash implementation with Ruby #216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

kares merged 1 commit into jruby:master from MariuszCwikla:issue_209_X509_Name_hash

Nov 8, 2020

Contributor

MariuszCwikla commented Nov 4, 2020

Fixes #209
Summary of changes:

OpenSSL hash algorithm switched from MD5 to SHA1. Furthermore, for calculations they are using canonical encoding now (X509_NAME_hash/asn1_string_canon)
MD5 version of hash is still present in Ruby API under hash_old
eql and <=> are also affected by the change in OpenSSL (see X509_NAME_cmp)


          Match OpenSSL::X509::Name.hash implementation with Ruby

a958df6

MariuszCwikla force-pushed the issue_209_X509_Name_hash branch from 485de5c to a958df6 Compare

November 5, 2020 08:23

kares merged commit e50c04b into jruby:master

Member

kares commented Nov 8, 2020

Thanks Mariusz, well done!

MariuszCwikla mentioned this pull request

Fix integer overflow in hash_old #218

Merged

kares pushed a commit that referenced this pull request


          [fix] integer overflow in hash_old (#218)

cb02f54

introduced in #216

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet