Fix SSLContext#ciphers= #222
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for fixing this. |
|
This looks a-ok to me but I didn't verify exact behavior against MRI. |
|
This is a good step forward! I will merge this but we need to do more verification and get a release out. |
kares
added a commit
that referenced
this pull request
Apr 27, 2021
setSuite params indicates necessary cipher suite initialization
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #221 and jruby/jruby#3100
However, this functionality is not fully compatible with ruby openssl. I did some investigation and apparently jruby-openssl was implemented based on openssl 0.9.x. Ruby 2.7 is using openssl 1.1.1.
There was a refactoring in openssl between 0.9.x and 1.1.1, e.g. following does work with ruby, but not with jruby:
but this works with both: