[feat] support alpn negotiation in ssl context #247
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* SSLSocket now implements `#alpn_protocol` * SSLContext onw implements `#alpn_protocols` annd `#alpn_select_cb` They will be used to set the alpn parameters when using jsse BCSSLEngine, which supports ALPN negotiation.
there's really no need to resort to BC engine
|
LGTM 🎊 I see you already linked an issue to autoclose, I'd recommend autoclosing this list of issues as well :) |
|
@kares thx for all the work you did recently, which is not visible in this PR, but made it possible! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up on getting ALPN finished (from #238) :
ruby-openssl;SSLSocketandSSLContextALPN ruby APIs:OpenSSL::SSL::SSLSocket#alpn_protocolOpenSSL::SSL::SSLContext#alpn_protocols (rw)OpenSSL::SSL::SSLContext#alpn_select_cb