-
Notifications
You must be signed in to change notification settings - Fork 19
Create Devtools package and its Roblox plugin #14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor comments. Great work!
packages/react-devtools-shared/src/devtools/views/Profiler/CommitTreeBuilder.luau
Show resolved
Hide resolved
return | ||
end | ||
|
||
if runModes.edit then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not good, I essentially make my entire game in Hoarcekat--I need it there!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep! For now I want to disable it to prevent any confusion about the plugin not working in edit mode.
It's definitely possible to make it work though, the plugin would just need to make sure to re-connect and clean up the connections correctly.
This PR sets up a Roblox plugin that re-implements the React developer extension
We cannot use the existing extensions (like the chrome or firefox extensions) because Roblox does not have a socket API, so it cannot communicate with them. That is why I built this plugin.
The goal was to get the profiler working, so the "components" tab is not implemented.
Notes
How to test it out
You will need the plugin and a few modification in your code before you render your root.
Build the plugin
Roblox setup
Here is an example of how to setup the devtools inside Roblox:
Screenshot of the extension