Code

Code cleanup#691

Code

Merged

maurei merged 74 commits intojson-api-dotnet:masterjson-api-dotnet/JsonApiDotNetCore:masterfrom

bart-degreed:code-cleanupCopy head branch name to clipboard

Mar 24, 2020

Commits

Commits on Feb 14, 2020

• Fixed: XML comment is not placed on a valid language element

  

  Bart Koelman

  committed
  e89c2d1

  Copy full SHA for e89c2d1

• Fixed: Convert to method group

  

  Bart Koelman

  committed
  8fb115f

  Copy full SHA for 8fb115f

• Fixed: Use null propagation

  

  Bart Koelman

  committed
  4100e7d

  Copy full SHA for 4100e7d

• Fixed: Use string interpolation expression

  

  Bart Koelman

  committed
  8c70342

  Copy full SHA for 8c70342

• Fixed: Use lambda expression

  

  Bart Koelman

  committed
  b04cadd

  Copy full SHA for b04cadd

• Fixed: Convert to compound assignment

  

  Bart Koelman

  committed
  56d200b

  Copy full SHA for 56d200b

• Fixed: Convert to 'using' declaration

  

  Bart Koelman

  committed
  a2a0f5a

  Copy full SHA for a2a0f5a

• Fixed: Use 'await using'

  

  Bart Koelman

  committed
  2f23e13

  Copy full SHA for 2f23e13

• Fixed: Convert to '?:' expression

  

  Bart Koelman

  committed
  53c0a08

  Copy full SHA for 53c0a08

• Fixed: Merge conditional expression

  

  Bart Koelman

  committed
  fd932c0

  Copy full SHA for fd932c0

• Fixed: Use object initializer

  

  Bart Koelman

  committed
  2e17fe7

  Copy full SHA for 2e17fe7

• Fixed: Qualifier is redundant

  

  Bart Koelman

  committed
  5db43f6

  Copy full SHA for 5db43f6

• Fixed: Using directive is not required by the code and can be safely removed

  

  Bart Koelman

  committed
  fd783ef

  Copy full SHA for fd783ef

• Fixed: Redundant explicit array type specification

  

  Bart Koelman

  committed
  340d34d

  Copy full SHA for 340d34d

• Fixed: Type argument specification is redundant

  

  Bart Koelman

  committed
  a2617d1

  Copy full SHA for a2617d1

• Fixed: Comparison with true is redundant

  

  Bart Koelman

  committed
  87773a4

  Copy full SHA for 87773a4

• Fixed: Redundant string interpolation

  

  Bart Koelman

  committed
  b6a9956

  Copy full SHA for b6a9956

• Fixed: Conditional access qualifier expression is known to be not null

  

  Bart Koelman

  committed
  2e8aa9f

  Copy full SHA for 2e8aa9f

• Fixed: Empty object or collection initializer list is redundant

  

  Bart Koelman

  committed
  ec1974a

  Copy full SHA for ec1974a

• Fixed: Redundant explicit array creation in argument of 'params' parameter

  

  Bart Koelman

  committed
  143139b

  Copy full SHA for 143139b

• Fixed: Type cast is redundant

  

  Bart Koelman

  committed
  3258c0f

  Copy full SHA for 3258c0f

• Fixed: The parameter {name} has the same default value

  

  Bart Koelman

  committed
  3d12105

  Copy full SHA for 3d12105

• Fixed: Empty argument list is redundant

  

  Bart Koelman

  committed
  50f8c1a

  Copy full SHA for 50f8c1a

• Fixed: Expression is always null

  

  Bart Koelman

  committed
  ea572a1

  Copy full SHA for ea572a1

• Fixed: Value assigned is not used in any execution path

  

  Bart Koelman

  committed
  889ea3d

  Copy full SHA for 889ea3d

• Fixed: Redundant 'IEnumerable.Cast<T>' call

  

  Bart Koelman

  committed
  b7cb5be

  Copy full SHA for b7cb5be

• Fixed: '??' right operand is always null

  

  Bart Koelman

  committed
  6fce99d

  Copy full SHA for 6fce99d

• Fixed: Redundant 'Object.ToString()' call

  

  Bart Koelman

  committed
  aaad695

  Copy full SHA for aaad695

• Fixed: Qualifier 'base.' is redundant

  

  Bart Koelman

  committed
  dc1a2b1

  Copy full SHA for dc1a2b1

• Fixed: The field is always assigned before being used and can be converted to local variable

  

  Bart Koelman

  committed
  09ea66e

  Copy full SHA for 09ea66e

• Fixed: Merge cast with type check

  

  Bart Koelman

  committed
  dc2dc11

  Copy full SHA for dc2dc11

Commits on Feb 17, 2020

• Fixed: Replace with single call to First(..)

  

  Bart Koelman

  committed
  c065f8a

  Copy full SHA for c065f8a

• Fixed: Replace 'Enumerable.Count()' invocation with collection count property access

  

  Bart Koelman

  committed
  b84797b

  Copy full SHA for b84797b

• Fixed: Use format specifier

  

  Bart Koelman

  committed
  67ae0e8

  Copy full SHA for 67ae0e8

• Fixed: Field is assigned but its value is never used

  

  Bart Koelman

  committed
  6c8c20c

  Copy full SHA for 6c8c20c

• Fixed: Field can be made readonly

  

  Bart Koelman

  committed
  77d93d4

  Copy full SHA for 77d93d4

• Fixed: Redundant method override

  

  Bart Koelman

  committed
  56e81b2

  Copy full SHA for 56e81b2

• Fixed: Method is never used

  

  Bart Koelman

  committed
  0685677

  Copy full SHA for 0685677

• Fixed: Base interface is redundant

  

  Bart Koelman

  committed
  2124c2c

  Copy full SHA for 2124c2c

• Fixed: Field is never used

  

  Bart Koelman

  committed
  89df3a8

  Copy full SHA for 89df3a8

• Fixed: Local variable is never used

  

  Bart Koelman

  committed
  46bafaa

  Copy full SHA for 46bafaa

• Fixed: Method return value is never used

  

  Bart Koelman

  committed
  0127ee4

  Copy full SHA for 0127ee4

• Fixed: Constructor is never used

  

  Bart Koelman

  committed
  705882e

  Copy full SHA for 705882e

• Fixed: shared instance is never used

  

  Bart Koelman

  committed
  8b1d50a

  Copy full SHA for 8b1d50a

• Fixed: Parameter is never used

  

  Bart Koelman

  committed
  ddc43d6

  Copy full SHA for ddc43d6

• Fixed: Method is never used

  

  Bart Koelman

  committed
  e654fb1

  Copy full SHA for e654fb1

• Fixed: Initializing field/property by default value is redundant

  

  Bart Koelman

  committed
  a2fe29c

  Copy full SHA for a2fe29c

• Fixed: Redundant base constructor call

  

  Bart Koelman

  committed
  d1a6203

  Copy full SHA for d1a6203

• Fixed: parameter hides outer local variable with the same name

  

  Bart Koelman

  committed
  631871e

  Copy full SHA for 631871e

• Fixed: Cannot resolve symbol 'dynamic'

  

  Bart Koelman

  committed
  9d1fd2e

  Copy full SHA for 9d1fd2e

• Fixed: Possible unintended reference comparison

  

  Bart Koelman

  committed
  428a182

  Copy full SHA for 428a182

• Fixed: Co-variant array conversion can cause run-time exception on write operation

  

  Bart Koelman

  committed
  2c0321a

  Copy full SHA for 2c0321a

• Fixed: Return value of pure method is not used

  

  Bart Koelman

  committed
  87fb6ff

  Copy full SHA for 87fb6ff

• Fixed: Auto-property can be made get-only

  

  Bart Koelman

  committed
  17134f8

  Copy full SHA for 17134f8

• Fixed: Inconsistent body style: use expression-bodied property

  

  Bart Koelman

  committed
  dbf8cbf

  Copy full SHA for dbf8cbf

• Fixed: Empty statement is redundant

  

  Bart Koelman

  committed
  243f82f

  Copy full SHA for 243f82f

• Fixed: Local variable can be declared in inner scope

  

  Bart Koelman

  committed
  d4938d5

  Copy full SHA for d4938d5

• Fixed: Join declaration and assignment

  

  Bart Koelman

  committed
  b9d70e8

  Copy full SHA for b9d70e8

• Fixed: Convert constructor to protected in abstract class

  

  Bart Koelman

  committed
  4d83cc3

  Copy full SHA for 4d83cc3

• Fixed: Replace with single call to FirstOrDefault/Count

  

  Bart Koelman

  committed
  51dd093

  Copy full SHA for 51dd093

• Fixed: Use single deconstruction declaration

  

  Bart Koelman

  committed
  bea8731

  Copy full SHA for bea8731

• Fixed: Removed unused using directives

  

  Bart Koelman

  committed
  995e114

  Copy full SHA for 995e114

• Fixed a few obvious naming violations

  

  Bart Koelman

  committed
  9a1e4b3

  Copy full SHA for 9a1e4b3

• Fixed: Virtual member that is never overridden

  

  Bart Koelman

  committed
  6964ca3

  Copy full SHA for 6964ca3

• Removed DefaultPageSize/RequestedPageSize from IPageService because where the calculated value comes from is an implementation detail and should not be exposed to external code that uses paging.

  

  Bart Koelman

  committed
  f0d7c4f

  Copy full SHA for f0d7c4f

• Fixed: Initializing property by default value is redundant

  

  Bart Koelman

  committed
  a50ab4d

  Copy full SHA for a50ab4d

• Reduced accessibility for some non-public types/members

  

  Bart Koelman

  committed
  e874f42

  Copy full SHA for e874f42

• Fixed: missing checkbox in Solution Configuration Manager

  

  Bart Koelman

  committed
  9a3ae13

  Copy full SHA for 9a3ae13

• Made non-public (and a few public) types sealed

  

  Bart Koelman

  committed
  1771ebd

  Copy full SHA for 1771ebd

• Fixed: Inconsistent modifiers style

  

  Bart Koelman

  committed
  e96260f

  Copy full SHA for e96260f

• Removed reference to xunit from benchmarks project, so that 'dotnet test' does not try to run tests from it

  

  Bart Koelman

  committed
  f20d1e9

  Copy full SHA for f20d1e9

• Empty commit to retry cibuild

  

  Bart Koelman

  committed
  dd10241

  Copy full SHA for dd10241

Commits on Mar 24, 2020

• Merge branch 'master' into code-cleanup

  maurei

  authored
  d5bdb8b

  Copy full SHA for d5bdb8b

• Update IQueryableExtensions.cs

  maurei

  authored
  7284204

  Copy full SHA for 7284204