-
-
Notifications
You must be signed in to change notification settings - Fork 158
Write enhancements (continued) #875
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Continuation of #851.
…e coordination from service.
Closed
…ory.AddToToManyRelationshipAsync()
…for GetSecondary either).
…nt test, fix bug in HasFkLeftSide method in repo
…et/JsonApiDotNetCore into write-enhancements
…opy/paste Update method in derived classes
maurei
approved these changes
Nov 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of #851.
This PR primarily concerns write operations and addresses several topics:
SaveChanges()
call, removing the need for internal transaction management.0
orGuid.Empty
.IResourceRepository
dependency in resource services withIResourceRepositoryAccessor
, which dynamically queries the IoC container for a compatible repository and forwards the request to it.IResourceHookExecutor
dependency in resource services withIResourceHookExecutorFacade
. Depending on startup options, we register an implementation that does nothing (the default) or delegate to hook executor.IHasMultipleErrors
, which users can add to their custom exceptions, so JADNC will serialize a proper error response for them. (ping @bjornharrtell)AddResourceRepository()
onIServiceCollection
, similar toAddResourceService()
. This registers repositories by their read and write interface, which is now needed due toIResourceRepositoryAccessor
usage. Note you only need this when not using service discovery.DbContext
.JsonApiOptions.RelatedIdMapper
property with settable properties onHasManyThroughAttribute
(to use non-default primary key names). For the other relationship kinds, we don't need this information anymore, as we rely on the user-defined EF Core mappings.200 OK
with{ data: null }
in PATCH responses without side effects, where we should return204 No Content
without a body.Fixes #353
Fixes #850
Fixes #852
Fixes #853
Fixes #578
Fixes #870
Fixes #790
Fixes #363
Fixes #690