Skip to content

Core#Dereferencing example schema: remove second dimension of array #1302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 4, 2022

Conversation

notEthan
Copy link
Contributor

I think this is probably what was intended - I don't see any reason for the arrays in this example to be nested. If I'm wrong and this is how the schema is supposed to be, the reference here to the schema containing the #item reference should be corrected from #/items to #/items/items.

Introduced 23ba42e1 - ping @awwright, not that I expect you to remember these lines six years later.

Copy link
Contributor

@handrews handrews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works either way, but yeah this seems less confusing and probably the original intent.

@handrews handrews merged commit 9f92f88 into json-schema-org:main Oct 4, 2022
@notEthan notEthan deleted the core_definitions_items branch May 30, 2023 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants