Skip to content

react/jsx-indent: Closing parenthese indentation #618

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
stefanbuck opened this issue Jun 2, 2016 · 4 comments · Fixed by #620
Closed

react/jsx-indent: Closing parenthese indentation #618

stefanbuck opened this issue Jun 2, 2016 · 4 comments · Fixed by #620
Labels
bug help wanted

Comments

@stefanbuck
Copy link

The indentation of the closing parentheses on return statements seems to be not working.

The following patterns are considered warnings:

return (
  <div />
  );
return (
  <div />);

The following patterns are not considered warnings:

return (
  <div />
);
return (<div />);
@ljharb
Copy link
Member

ljharb commented Jun 2, 2016

The examples you've mentioned are exactly how it should be working. Is it working differently?

@stefanbuck
Copy link
Author

Mhhh, good to know. So it must be a configuration issue, right? I tried to find the conflicting rule without success. Would it be possible that you take a look?

https://github.com/stefanbuck/eslint-plugin-react-issues-618

@ljharb
Copy link
Member

ljharb commented Jun 3, 2016

@stefanbuck thanks for the repro repo! It definitely looks like a bug.

@stefanbuck
Copy link
Author

Is jsxp-indent.js the right place to fix it? I'll try to come up with a PR for this.

stefanbuck pushed a commit to stefanbuck/eslint-plugin-react that referenced this issue Jun 3, 2016
Fix indent handling for closing parenthese to fix jsx-eslint#618
51ab7ad
@stefanbuck stefanbuck mentioned this issue Jun 3, 2016
Merged
stefanbuck pushed a commit to stefanbuck/eslint-plugin-react that referenced this issue Jun 3, 2016
Fix indent handling for closing parenthese to fix jsx-eslint#618
af8bb41
stefanbuck pushed a commit to stefanbuck/eslint-plugin-react that referenced this issue Jun 4, 2016
Fix indent handling for closing parenthese to fix jsx-eslint#618
d9e6c6f
stefanbuck pushed a commit to stefanbuck/eslint-plugin-react that referenced this issue Jul 28, 2016
Fix indent handling for closing parenthese to fix jsx-eslint#618
71ac08e
ljharb pushed a commit to stefanbuck/eslint-plugin-react that referenced this issue Dec 28, 2018
@ljharb
Fix indent handling for closing parenthese to fix jsx-eslint#618
2611207
ljharb pushed a commit to stefanbuck/eslint-plugin-react that referenced this issue Dec 13, 2019
@ljharb
[Fix] jsx-indent: Fix indent handling for closing parentheses
d5bc7a7 
Fixes jsx-eslint#618.
stefanbuck pushed a commit to stefanbuck/eslint-plugin-react that referenced this issue Dec 16, 2019
[Fix] jsx-indent: Fix indent handling for closing parentheses
3e6cc15 
Fixes jsx-eslint#618.
ljharb pushed a commit to stefanbuck/eslint-plugin-react that referenced this issue Dec 27, 2019
@ljharb
[Fix] jsx-indent: Fix indent handling for closing parentheses
088c5f6 
Fixes jsx-eslint#618.
ljharb pushed a commit to stefanbuck/eslint-plugin-react that referenced this issue May 9, 2020
@ljharb
[Fix] jsx-indent: Fix indent handling for closing parentheses
bba0015 
Fixes jsx-eslint#618.
ljharb pushed a commit to stefanbuck/eslint-plugin-react that referenced this issue May 13, 2020
@ljharb
[Fix] jsx-indent: Fix indent handling for closing parentheses
85823ee 
Fixes jsx-eslint#618.
ljharb pushed a commit to stefanbuck/eslint-plugin-react that referenced this issue Oct 15, 2020
@ljharb
[Fix] jsx-indent: Fix indent handling for closing parentheses
12d8b40 
Fixes jsx-eslint#618.
@ljharb ljharb closed this as completed in c9b7294 Feb 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug help wanted
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix indentation of closing parentheses stefanbuck/eslint-plugin-react
2 participants
@ljharb @stefanbuck