Skip to content

docs: Add a note in the README about immutability #388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

pierreprinetti
Copy link
Member

As mentioned in #275, the fact that we haven't implemented mutability yet should be mentioned in the README.

@pierreprinetti pierreprinetti requested a review from mandre May 5, 2025 09:39
@github-actions github-actions bot added the semver:patch No API change label May 5, 2025
@@ -22,6 +22,10 @@ encounter bugs, unfinished features, or breaking changes. We encourage you to
contribute, file issues, and help improve the project as we continue to work on
it!

### Known limitations

ORC does not handle mutability yet. This means that in order to change a resource in OpenStack, you must delete it and recreate it.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't technically true, we have implemented mutability for the security group rules, so I would rather say that it is only supported for a limited set of resources at the moment and that we haven't had a chance to add mutability for other resources yet (contributions welcome).

For all the fields that do not support mutability yet, we've blocked their update at the API level, meaning that you'll get a clear error message from the kube API server if you ever try to update them.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the sake of clarity, I'd go for the simpler statement that mutability is not implemented. As a matter of fact, mutability of the secgroup rules is just an unintended consequence of how we implemented rules.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver:patch No API change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants