Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix a bug that caused failure when using --runner and --http-openapi3 together #1213

Merged
merged 1 commit into from
Apr 9, 2025

Conversation

k1LoW
Copy link
Owner

@k1LoW k1LoW commented Apr 9, 2025

Fix #1207

@k1LoW k1LoW self-assigned this Apr 9, 2025
@k1LoW k1LoW added the bug Something isn't working label Apr 9, 2025

This comment has been minimized.

@k1LoW k1LoW force-pushed the fix-http-runner-validator branch from 3446992 to 57f8c84 Compare April 9, 2025 14:53
Copy link
Contributor

github-actions bot commented Apr 9, 2025

BenchmarkManyRunbooks-4

main (-) #1213 (e0fdf5e) +/-
Number of iterations 1 1 0
Nanoseconds per iteration 3,703,481,290 ns/op 3,881,739,660 ns/op 178,258,370 ns/op
Bytes allocated per iteration 1,388,464,128 B/op 1,388,862,448 B/op 398,320 B/op
Allocs per iteration 19,567,219 allocs/op 19,567,384 allocs/op 165 allocs/op
Metadata
main (-) #1213 (e0fdf5e)
goos linux linux
goarch amd64 amd64
pkg github.com/k1LoW/runn github.com/k1LoW/runn
cpu AMD EPYC 7763 64-Core Processor AMD EPYC 7763 64-Core Processor

BenchmarkOpenAPI3-4

main (-) #1213 (e0fdf5e) +/-
Number of iterations 1 1 0
Nanoseconds per iteration 3,012,946,048 ns/op 2,928,138,368 ns/op -84,807,680 ns/op
Bytes allocated per iteration 1,264,996,488 B/op 1,264,923,704 B/op -72,784 B/op
Allocs per iteration 21,234,174 allocs/op 21,234,097 allocs/op -77 allocs/op
Metadata
main (-) #1213 (e0fdf5e)
goos linux linux
goarch amd64 amd64
pkg github.com/k1LoW/runn github.com/k1LoW/runn
cpu AMD EPYC 7763 64-Core Processor AMD EPYC 7763 64-Core Processor

BenchmarkSingleRunbook-4

main (-) #1213 (e0fdf5e) +/-
Number of iterations 25 25 0
Nanoseconds per iteration 47,913,024 ns/op 47,560,907 ns/op -352,117 ns/op
Bytes allocated per iteration 23,254,560 B/op 23,254,971 B/op 411 B/op
Allocs per iteration 189,090 allocs/op 189,098 allocs/op 8 allocs/op
Metadata
main (-) #1213 (e0fdf5e)
goos linux linux
goarch amd64 amd64
pkg github.com/k1LoW/runn github.com/k1LoW/runn
cpu AMD EPYC 7763 64-Core Processor AMD EPYC 7763 64-Core Processor

Reported by octocov

Copy link
Contributor

github-actions bot commented Apr 9, 2025

Code Metrics Report

main (422dc48) #1213 (e0fdf5e) +/-
Coverage 63.3% 63.3% +0.0%
Code to Test Ratio 1:0.7 1:0.7 +0.0
Test Execution Time 7m10s 7m11s +1s
Details
  |                     | main (422dc48) | #1213 (e0fdf5e) |  +/-  |
  |---------------------|----------------|-----------------|-------|
+ | Coverage            |          63.3% |           63.3% | +0.0% |
  |   Files             |             78 |              78 |     0 |
  |   Lines             |           9069 |            9068 |    -1 |
  |   Covered           |           5746 |            5746 |     0 |
+ | Code to Test Ratio  |          1:0.7 |           1:0.7 |  +0.0 |
  |   Code              |          16694 |           16693 |    -1 |
  |   Test              |          12816 |           12816 |     0 |
- | Test Execution Time |          7m10s |           7m11s |   +1s |

Code coverage of files in pull request scope (80.5% → 80.6%)

Files Coverage +/-
operator.go 80.6% +0.0%

Reported by octocov

@k1LoW k1LoW merged commit fbd426a into main Apr 9, 2025
9 checks passed
@k1LoW k1LoW deleted the fix-http-runner-validator branch April 9, 2025 15:19
@github-actions github-actions bot mentioned this pull request Apr 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Unable to use --runner and --http-openapi3 options together in runn CLI
1 participant