refactor(metarepos): suppress logging in GetMetadata method #1007
+342
−73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1007 +/- ##
==========================================
- Coverage 79.74% 79.66% -0.08%
==========================================
Files 178 178
Lines 21478 21573 +95
==========================================
+ Hits 17127 17186 +59
- Misses 3562 3595 +33
- Partials 789 792 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
hungryjang
approved these changes
Mar 6, 2025
ijsong
force-pushed
the
sn_bootstrap_logging
branch
from
5f67987 to
fb442bb
Compare
ijsong
force-pushed
the
mr_suppress_verbose_log
branch
from
5a28ec4 to
f102f80
Compare
ijsong
force-pushed
the
sn_bootstrap_logging
branch
from
fb442bb to
5851201
Compare
ijsong
force-pushed
the
mr_suppress_verbose_log
branch
from
f102f80 to
f766d2a
Compare
ijsong
force-pushed
the
sn_bootstrap_logging
branch
from
5851201 to
b9f9a7a
Compare
ijsong
force-pushed
the
mr_suppress_verbose_log
branch
from
f766d2a to
b7ed043
Compare
ijsong
force-pushed
the
sn_bootstrap_logging
branch
from
b9f9a7a to
daac6fa
Compare
ijsong
force-pushed
the
mr_suppress_verbose_log
branch
from
b7ed043 to
3d9d134
Compare
ijsong
force-pushed
the
sn_bootstrap_logging
branch
from
daac6fa to
5a2296a
Compare
ijsong
force-pushed
the
mr_suppress_verbose_log
branch
from
3d9d134 to
1f70ec6
Compare
ijsong
force-pushed
the
sn_bootstrap_logging
branch
from
5a2296a to
c4b17f7
Compare
ijsong
force-pushed
the
mr_suppress_verbose_log
branch
from
1f70ec6 to
6832c7b
Compare
…e metrics This commit enables Varlog to support both new and deprecated OpenTelemetry runtime metrics. Previously, Varlog only supported the deprecated runtime instrumentation. This change ensures backward compatibility by simultaneously setting the `OTEL_GO_X_DEPRECATED_RUNTIME_METRICS` environment variable and using the new version. This enhancement allows Varlog to leverage the latest OpenTelemetry features while maintaining compatibility with older versions, collecting more comprehensive runtime metrics.
Add validation for empty payloads in the Append RPC. If there is no payload in the append request, the RPC returns a gRPC status code of InvalidArgument.
This PR adds a new flag `--enable-development-mode` to enable development mode for the logger. If it is true, the logger panics at the DPanic level.
This PR adds error handling to prevent panic when an unexpected LLSN is encountered in backup and primary replicas. If `--enable-development-mode` is set, panic occurs as before.
… commit context Enhance logging while bootstrapping log stream replica: - Add `MarshalLogObject` method to `CommitContext` and `RecoveryPoints` for structured logging. - Add logs to print more useful information during data loading on restarts.
Change logging level to Debug for the GetMetadata method in raft_metadata_repository.go to reduce verbosity.
ijsong
force-pushed
the
sn_bootstrap_logging
branch
from
c4b17f7 to
6b6a5b7
Compare
ijsong
force-pushed
the
mr_suppress_verbose_log
branch
from
6832c7b to
93ed36d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Change logging level to Debug for the GetMetadata method in
raft_metadata_repository.go to reduce verbosity.