Skip to content

feat: add SNMP trap receiver provider. #4884

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

rahulrajesh21
Copy link

@rahulrajesh21 rahulrajesh21 commented May 23, 2025

Closes #2112
/claim #2112

📑 Description

The SNMP Provider allows Keep to receive and process SNMP traps from network devices, converting them into alerts within the Keep platform.

  • Implemented SNMP Provider with trap receiver functionality
  • Convert SNMP traps to Keep alerts
  • Configure custom severity mappings for different OIDs
Timeline.1.mp4

✅ Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

ℹ Additional Information

The SNMP Provider includes OID translation for human-readable alerts. Added dependencies: pysnmp, pysnmp-lextudio, pyasn1.

Copy link

vercel bot commented May 23, 2025

@rahulrajesh21 is attempting to deploy a commit to the KeepHQ Team on Vercel.

A member of the Team first needs to authorize it.

@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label May 23, 2025
@CLAassistant
Copy link

CLAassistant commented May 23, 2025

CLA assistant check
All committers have signed the CLA.

@dosubot dosubot bot added Feature A new feature Provider Providers related issues labels May 23, 2025
@rahulrajesh21 rahulrajesh21 reopened this May 23, 2025
@dosubot dosubot bot added size:XL This PR changes 500-999 lines, ignoring generated files. and removed size:L This PR changes 100-499 lines, ignoring generated files. labels May 24, 2025
Copy link
Member

@shahargl shahargl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor changes needed, all in all looks surprisingly good.

one thing however - for such "complicated" providers we usually asks contributors to create some script/doc to help us maintain it - mainly a way to reproduce an end-to-end like the video you sent

@shahargl
Copy link
Member

@rahulrajesh21 ?

@rahulrajesh21
Copy link
Author

@shahargl Almost done with e2e test.

@rahulrajesh21
Copy link
Author

@shahargl can you review my e2e testing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🙋 Bounty claim Feature A new feature Provider Providers related issues size:XL This PR changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[🔌 Provider]: SNMP provider
3 participants