Always install the correct version with pip_build #595
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pip_build while create whl files in `/dist`, which aren't cleaned up by the script unless you do so manually. The script would install the first `.whl` it saw in `/dist`, which means if you have been building multiple versions of keras-core, the install script might grab the wrong one. This makes sure to always grab the correct versioned `.whl`. Alternately we could clear the `/dist` dir each time we build.
fchollet
approved these changes
Jul 24, 2023
mattdangerw
added a commit
to mattdangerw/keras-hub
that referenced
this pull request
Jul 24, 2023
Mirror keras-team/keras-core#595 for keras-nlp
mattdangerw
added a commit
to keras-team/keras-hub
that referenced
this pull request
Jul 25, 2023
Mirror keras-team/keras-core#595 for keras-nlp
Tusespifump1o
added a commit
to Tusespifump1o/keras-nlp
that referenced
this pull request
Aug 26, 2024
Mirror keras-team/keras-core#595 for keras-nlp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pip_build while create whl files in
/dist, which aren't cleaned up by the script unless you do so manually.The script would install the first
.whlit saw in/dist, which means if you have been building multiple versions of keras-core, the install script might grab the wrong one.This makes sure to always grab the correct versioned
.whl. Alternately we could clear the/distdir each time we build.