fix(developer): improve .kmx output consistency for cross-platform 🚑 #8388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes two issues: 1. `COMP_KEY` structure had padding that was not always zeroed out. Made this explicit. 2. Rule sorting could be inconsistent when re-sorting rules that use `+ any() > ...`, which are expanded at compile time into multiple rules, and which ended up with identical sort keys due to lack of precision. This relates to #8381 but only adds differentiation for the otherwise ambiguous rule sort keys, and does not fix that issue, which requires further investigation.
User Test ResultsTest specification and instructions User tests are not required Test Artifacts
|
mcdurdin
changed the title
Base automatically changed from
chore/developer/cross-platform-fixups-for-wasm
to
feature-kmcompx
March 9, 2023 07:41
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes two issues:
COMP_KEYstructure had padding that was not always zeroed out. Made this explicit.Rule sorting could be inconsistent when re-sorting rules that use
+ any() > ..., which are expanded at compile time into multiple rules, and which ended up with identical sort keys due to lack of precision. This relates to bug(developer): rule sorting algorithm may sort touch or other non-character keys wrongly #8381 but only adds differentiation for the otherwise ambiguous rule sort keys, and does not fix that issue, which requires further investigation.@keymanapp-test-bot skip