Skip to content

Move get_cpu guessing into _possible_lib_location #626

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 5, 2022

Conversation

misl6
Copy link
Member

@misl6 misl6 commented Jun 4, 2022

  • Not all the platforms need a cpu while guessing for libjvm
  • Adding a mapping in MACHINE2CPU for platforms where the cpu doesn't need to be guessed may lead to unexpected bugs in future.
  • I noticed it while working on PR Uses cibuildwheel for releases #625 , as tests on Apple Silicon are failing due to:
     self = <json.decoder.JSONDecoder object at 0x101d05ea0>
      [235](https://github.com/kivy/pyjnius/runs/6739396035?check_suite_focus=true#step:12:236)
      s = 'WARNING: Not able to assign machine() = arm64 to a cpu value!\n         Using cpu = \'arm64\' instead!\n["-Dtest.var0...=value", "-Dtest.var35=value", "-Dtest.var36=value", "-Dtest.var37=value", "-Dtest.var38=value", "-Dtest.var39=value"]'
      [236](https://github.com/kivy/pyjnius/runs/6739396035?check_suite_focus=true#step:12:237)
      idx = 0
    
    (basically the test parses what can be found onstdout as a json, but it fails as an unexpected WARNING log is also on stdout buffer)
    The test may be changed in order to avoid this kind of edge case, but this time worked great to improve our codebase 😄 .

@misl6 misl6 merged commit 57e3ea0 into kivy:master Jun 5, 2022
@misl6 misl6 deleted the fix/get-cpu branch June 5, 2022 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants