Move get_cpu guessing into _possible_lib_location #626
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cpu
while guessing forlibjvm
MACHINE2CPU
for platforms where the cpu doesn't need to be guessed may lead to unexpected bugs in future.stdout
as a json, but it fails as an unexpectedWARNING
log is also onstdout
buffer)The test may be changed in order to avoid this kind of edge case, but this time worked great to improve our codebase 😄 .