Skip to content

PyPy: Fixes a segfault + add tests #627

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 18, 2022
Merged

Conversation

misl6
Copy link
Member

@misl6 misl6 commented Jun 12, 2022

  • Add test rules for PyPy
  • Fixed a test that may fail on PyPy (not on CI as python is available as an alias)
  • Disabled tests for x86 on PyPy
  • Removes usage (was intended as a temp fix) of PyUnicode_DecodeUTF16, which was segfaulting on PyPy (Fixes on Cython have been introduced here: cython/cython@5c9b32c)

@misl6
Copy link
Member Author

misl6 commented Jun 14, 2022

@tshirtman , maybe you want to give it a look before the merge?

Copy link
Member

@tshirtman tshirtman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)
Edit: we don't currently set a minimum version of cython in the pyproject.toml, maybe it's a good time to do so, asking for the version with that fix or newer?

@misl6
Copy link
Member Author

misl6 commented Jun 18, 2022

LGTM :)
Edit: we don't currently set a minimum version of cython in the pyproject.toml, maybe it's a good time to do so, asking for the version with that fix or newer?

Good point! I guess is better to ask for Cython>=0.29.30 (as is the latest available, it contains the needed fixes, and seems to work great).

BTW, I see some improvements (regarding Cython version) that could be made to the CI , pyproject.toml and setup.py. But, may go outside of the scope of this PR, so looks cleaner to submit a subsequent PR (seems easy and should land in a couple of hours). (I will refer to this PR, so we can keep track of it)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants