Add the <base> tag *before* the document html is injected into the DOM #343
Comments
|
EDIT: I've edited the regex above to replace the |
This was referenced Feb 24, 2018
|
Fixed by #354 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
After a fair amount of experimentation with #341, I've realized that some of the issues I describe in my last post there are caused by the fact that we're injecting the
<base>tag into the document at the wrong time.The problem is that we're adding the base tag after we've already injected the document into the DOM, but this is too late: any local references to stylesheets or javascript in the document start loading before the base href is seen by the browser. The base href has to be in the header at the moment we inject the document into the DOM. This may well account for the issues you, @mossroy , were noticing with stylesheets in the serviceworker mode, and it will impact on JavaScript in that mode in the future, if we get it working. Of course this doesn't matter for hyperlinks only, as they are only loaded on click.
The reason jQuery mode CSS nevertheless works with the base tag in Kiwix-JS is simply because links are loaded as raw CSS into
<style>tags. But that's not how serviceworker functions. As for Kiwix-JS-Windows, I was tearing my hair out because my cached stylesheets in the file system would sometimes load but sometimes not, and I had put some workarounds in place (root-relative URLs for stylesheets) to make it work. But #341 exposed the real issue. I can only continue with #341 , if we correct this problem first.The solution:
Note: It's important, when using the .write() function that the baseUrl should be written into the header before any CSS links. The browser reads each line as it's written to the document and acts on it. An alternative to the above is to use:
articleContent.documentElement.innerHTML = htmlArticle;but this method requires that we void the iframe earlier in the code. The above method voids it in the process of writing to it.
The text was updated successfully, but these errors were encountered: