Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify the source code for hiding/showing of HTML elements #78

Closed
mossroy opened this issue Apr 1, 2014 · 2 comments · Fixed by #1102
Closed

Simplify the source code for hiding/showing of HTML elements #78

mossroy opened this issue Apr 1, 2014 · 2 comments · Fixed by #1102

Comments

@mossroy
Copy link
Contributor

mossroy commented Apr 1, 2014

It's becoming a bit complicated to maintain all these .hide() and .show()

@mossroy mossroy added this to the v1.2 milestone Apr 1, 2014
@mossroy
Copy link
Contributor Author

mossroy commented Apr 1, 2014

Maybe it should be done at the same time as #74

@Jaifroid
Copy link
Member

There is a lot of repeated code, whether it's jQuery hide and show statements or native JS equivalents. These hide or show UI elements when the Home button is clicked, when the Random button is clicked, when a search is launched, when the user goes to Configuration or About. A lot of the code is the same and could be tidied away into non-jQuery functions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants