-
-
Notifications
You must be signed in to change notification settings - Fork 154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert jQuery statements that manipulate CSS to their native equivalents #920
Comments
Another not so difficult issue. Mind if I take this one up? @Jaifroid |
Yes of course, please do. |
Note that some of these will involve iterating over the collection of nodes selected by
|
Awesome. I'll get started. |
Alright! Thank you for informing. I'll be careful. Also if you don't mind me asking, why are we still supporting IE 11? And how long do we plan to do that? Just wanted to understand the thought process behind it. |
Good question. There are a number of old browsers we still try to support, either due to a conservative user base (very old Firefox) or to frameworks that still rely on old browsers or web views, and IE11 is a kind of baseline that ensures very wide compatibility. The medium-term aim is to start using modern code (probably TypeScript too) and compile down to our target browsers -- see #554. We're not there yet, due to lack of human-power to work on these things, hence we try to keep support manually for now till we can implement that issue. Where a feature cannot be done in a compatible way, we bypass that feature for old browsers in the app. An example is Service Worker support, which is now the default. What we still call "JQuery mode" (but hopefully can stop calling it that soon) is the version that is deprecated but still compatible with almost anything. |
Okay, I am opening a PR for this, but I am not sure if I've been on the right track. Just take a look, @Jaifroid . |
Sub-issue of #367. This will involve converting jQeury
$('.selector')
statements toquerySelector
orquerySelectorAll
, iterating over all selected nodes where necessary. Also deal with adding, removing or toggling CSS.The text was updated successfully, but these errors were encountered: