Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use native es6 modules instead of require js #1025

Merged
merged 74 commits into from
Jul 2, 2023
Merged
Changes from 1 commit
Commits
Show all changes
74 commits
Select commit Hold shift + click to select a range
b6e9825
Working but not fontawesome
Jaifroid Jun 18, 2023
0788a14
Now with fontawesome
Jaifroid Jun 18, 2023
9337018
Restore menu collapsing
Jaifroid Jun 18, 2023
032405c
Initial specification of SW files
Jaifroid Jun 18, 2023
d6f855e
Remove unneeded permissions
Jaifroid Jun 18, 2023
16ec547
Remove dependencies managed by NPM
Jaifroid Jun 18, 2023
a8b2c9c
Fix tests
Jaifroid Jun 18, 2023
bc24477
Make sure common-js can run
Jaifroid Jun 18, 2023
b449b7c
Add webpMachine loading
Jaifroid Jun 18, 2023
9393259
Fix test_pwa_server
Jaifroid Jun 18, 2023
63f5c72
Merge branch 'main' into Use-native-ES6-modules-instead-of-RequireJS
Jaifroid Jun 18, 2023
c429109
Add babel, rollup, vite configurations
Jaifroid Jun 19, 2023
91ceffd
Completely remove require.js
Jaifroid Jun 19, 2023
de31135
Miscellaneous
Jaifroid Jun 19, 2023
31d9963
Import jQuery directly
Jaifroid Jun 19, 2023
b4e5ab5
Package-lock and ignore
Jaifroid Jun 19, 2023
5bb4f77
Merge branch 'main' into Use-native-ES6-modules-instead-of-RequireJS
Jaifroid Jun 23, 2023
e3948eb
Merge branch 'main' into Use-native-ES6-modules-instead-of-RequireJS
Jaifroid Jun 24, 2023
f694201
Fix more ESLint issues
Jaifroid Jun 24, 2023
0b44354
Another attempt to make jQuery available globally
Jaifroid Jun 24, 2023
722da9b
Use NPM for Bootstrap and jQuery
Jaifroid Jun 25, 2023
261d1fa
Add rollup config to deal with bootstrap and jquery
Jaifroid Jun 25, 2023
7b9ee6f
Remove Sauce Labs tests
Jaifroid Jun 25, 2023
3779414
Remove unneeded require
Jaifroid Jun 25, 2023
f629fc8
Correct ESLint for nightwatch_runner
Jaifroid Jun 25, 2023
f8706a4
Remove vulnerabilities
Jaifroid Jun 25, 2023
191b119
Try upgrading nightwatch
Jaifroid Jun 25, 2023
c58b5db
Test running nightwatch on gha
Jaifroid Jun 26, 2023
c7fc63a
Fix ESLint issues
Jaifroid Jun 26, 2023
431418d
Try CI Unite tests with testcafe on gh-actions
Jaifroid Jun 26, 2023
dfa85a1
Add headless
Jaifroid Jun 26, 2023
1ec7feb
Remove nightwatch
Jaifroid Jun 26, 2023
967805b
Add test for all three browsers
Jaifroid Jun 26, 2023
7902c3c
Remove start-server-and-test
Jaifroid Jun 26, 2023
53c618a
Increase timeout for tests
Jaifroid Jun 26, 2023
08fcb01
Fix double-quoted strings
Jaifroid Jun 26, 2023
ba3dd4b
Add a build test and mac
Jaifroid Jun 26, 2023
512cd2b
Consolidate some tests
Jaifroid Jun 26, 2023
a0776f9
Try to fix Mac test
Jaifroid Jun 26, 2023
ad4b7e3
Try again with Safari
Jaifroid Jun 26, 2023
8aa988a
Update CI.yml
Jaifroid Jun 26, 2023
5b3af45
Disable mac and increase timeout
Jaifroid Jun 26, 2023
7c364df
Run unit tests in windows sequentially
Jaifroid Jun 26, 2023
6a23dd9
Lower version of fontawesome to support IE11
Jaifroid Jun 26, 2023
10aac0f
Add more robust dataURItoUint8Array converter
Jaifroid Jun 26, 2023
b541050
Update contribution guide
Jaifroid Jun 27, 2023
3f3f3a0
Finesse contributing guidelines
Jaifroid Jun 27, 2023
cb2ce04
Finesse contributing text and mention testing platform
Jaifroid Jun 27, 2023
fed154d
Fix image loading in IE11
Jaifroid Jul 1, 2023
3686d3e
Ensure dist has files needed to build apps
Jaifroid Jul 1, 2023
483c94d
Remove last of nightwatch
Jaifroid Jul 1, 2023
cffb3e9
Update publish-extension.yaml
Jaifroid Jul 1, 2023
cbc6520
Update publish-extension.yaml
Jaifroid Jul 1, 2023
82bc0d8
Add clearer information about support
Jaifroid Jul 1, 2023
8653ba0
Ensure the distribution version is published to docker
Jaifroid Jul 2, 2023
1119183
Add logic to build all apps from dist
Jaifroid Jul 2, 2023
5b5484f
Update Release.yml
Jaifroid Jul 2, 2023
0bfe732
Fix modifying appVersion
Jaifroid Jul 2, 2023
6d3ef31
Correct typo
Jaifroid Jul 2, 2023
ffaa79b
Build only minified version
Jaifroid Jul 2, 2023
b15e246
Remove .map files from bundles
Jaifroid Jul 2, 2023
a5143bd
Add some diagnostics
Jaifroid Jul 2, 2023
d498653
Don't overwrite manifest.json with ubuntu_touch version!
Jaifroid Jul 2, 2023
dad1b99
Add more diagnostics
Jaifroid Jul 2, 2023
728342b
Even more diagnostics
Jaifroid Jul 2, 2023
e63bd00
Don't install unneeded packages
Jaifroid Jul 2, 2023
839a826
Update package_firefox_extension.sh
Jaifroid Jul 2, 2023
336f86c
Final script cleanup
Jaifroid Jul 2, 2023
6e7dd90
Update README.md
Jaifroid Jul 2, 2023
47116eb
Fix regression caused by new loading method for webpHero
Jaifroid Jul 2, 2023
d8c6b0d
Add new packages to acknowledgements
Jaifroid Jul 2, 2023
b62334e
Remove packages no longer used
Jaifroid Jul 2, 2023
f86377d
Remove unused packages
Jaifroid Jul 2, 2023
8650815
Make sure both final lines are green
Jaifroid Jul 2, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update README.md
Jaifroid committed Jul 2, 2023
commit 6e7dd9069d768fe83b0167f2224b43f2132fd6b3
12 changes: 8 additions & 4 deletions README.md
Original file line number Diff line number Diff line change
@@ -88,10 +88,14 @@ These platforms/browsers are deprecated. We still partially test against them, a
### Installing unsigned extensions in Chromium

If you need to install an unsigned extension version, e.g. if your browser doesn't support Manifest V3, then you will need to download an unsigned ZIP file from
a relevant directory in https://download.kiwix.org/release/browsers/, or else a nightly version from https://download.kiwix.org/nightly/. Unzip this extension into
a folder, and note the location. Open the extension management page in your browser, e.g. chrome://extensions/ or edge://extensions/, and turn on Developer mode.
Then select "Load unpacked" and choose the folder that contains the unzipped extension. The browser will periodically ask you if you want to keep developer mode
extensions installed.
a relevant directory in https://download.kiwix.org/release/browsers/, or else a nightly version from https://download.kiwix.org/nightly/. Open the extension
management page in your browser, e.g. chrome://extensions/ or edge://extensions/, and turn on Developer mode. Now, you should be able to drag and drop the ZIP
file into this page. Verify the extension is showing in the management page.

Alternatively, if drag-and-drop is difficult, you can instead unzip the extension ZIP into a folder, and note the location. Then select "Load unpacked" and choose
the folder that contains the unzipped extension.

The browser will periodically ask you if you want to keep developer mode extensions installed.

### Limitations