- Sponsor
-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
changed jquery to safe mode in UI #1215
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A good start, thanks! Please note that there will be a bunch of strings in app.js
and uiUtil.js
, and possibly others that will also need changing. These are, effectively, the strings in the json file that have IDs beginning with dialog-
.
Did a full repo search for |
Thanks for this! I'll review and test properly when I get time, but for now I noticed the small issue above. |
What Spanish and French equivalent of "now deprecated" should I remove? |
Look for the words "obsoleto" (Spanish) and "obsolète" (French). |
The capitalization is a little off. Will fix it asap. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Some small niggly details with the translations below.
Also note that if viewing on GitHub, it hides some of the "conversations" above, and you have to click on "5 hidden conversation ... show more" to see all my suggested corrections. |
Co-authored-by: Jaifroid <egk10@cam.ac.uk>
Sorry for the delay, had a busy weekend. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's looking good, thank you very much! There are the very very last things listed below. While you're doing those, I'll test the UI manually in my browser in the different languages. Then we'll be ready to merge!
Manual tests in French and Spanish are all good! |
@Jaifroid I've made the requested changes and hopefully, we didn't miss any minor details. Please go ahead and merge the changes once you're satisfied with them. |
Great, it all looks good to me. Thank you very much for this PR. I've been unsatisfied for a long time with the name "JQuery Mode", so your original suggestion of "Safe Mode", and this PR, fix an irritation, and also give this mode a new purpose. I'll merge now. |
Happy to contribute! |
resolve #1197
I've changed
Jquery
toSafe
in the UI. Note that thes
insafe mode
is capitalized as it looked much cleaner than the uncapitalized version.@Jaifroid I'll translate the same strings to French and Spanish once you are happy with the changes I've made in English.