Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix duplicate credits in about section #1228

Merged
merged 2 commits into from
Mar 15, 2024
Merged

Fix duplicate credits in about section #1228

merged 2 commits into from
Mar 15, 2024

Conversation

dan-niles
Copy link
Contributor

The credits in the About section are duplicated as shown below:
image

I fixed it by seperating the bullet points into seperate entries in the i18n translation files.

@Jaifroid
Copy link
Member

Thank you! I'll take a look.

@Jaifroid
Copy link
Member

I confirm this is all fine! I'll merge now.

@Jaifroid
Copy link
Member

Many thanks for the PR!

Copy link
Member

@Jaifroid Jaifroid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, I spoke a bit too soon about merging, and have noticed that you're relying on a side-effect. But the good news is it will take about 1 minute for you to fix!

@dan-niles dan-niles requested a review from Jaifroid March 15, 2024 03:33
Copy link
Member

@Jaifroid Jaifroid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, all fixed now! Will merge.

@Jaifroid Jaifroid merged commit 596a44a into kiwix:main Mar 15, 2024
6 checks passed
@dan-niles dan-niles deleted the fix-duplicate-credits branch March 15, 2024 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants