-
-
Notifications
You must be signed in to change notification settings - Fork 231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add iso date support #68
base: master
Are you sure you want to change the base?
Conversation
Nice idea! I can see how this could be useful, but I believe it would be to the benefit of the users' freedom if we could deploy the option as a standalone, much just like the current Also, with the current overriding design, in order for the ISO date to be actually displayed both the Please feel free to share your thoughts on this approach : ) |
red, | ||
underline, | ||
yellow | ||
} = chalk; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unneeded changes, like this one, should also be removed for the PR to be merged
@@ -47,6 +45,7 @@ | |||
"displayScope": true, | |||
"displayBadge": true, | |||
"displayDate": false, | |||
"displayISODate": false, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
- Type: `Boolean` | ||
- Default: `false` | ||
|
||
Override `displayDate` format and show the current local date in ISO 8601 `YYYY-MM-DDTHH:mm:ss.TDZ` format. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Display the current local date in ISO 8601 `YYYY-MM-DDTHH:mm:ss.TDZ` format.
I cen help out with these too if u need! Happy to conribute! |
This PR add a little functionality to override currently data format used from local to ISO as optional, so turning the flag
displayISODate
to true makes the timestamp to be in ISO 8601 format.