-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: refactor repository layout #1554
Conversation
dfe7f27
to
0b8ce50
Compare
ccd08a6
to
65eff10
Compare
Codecov ReportBase: 60.87% // Head: 60.64% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1554 +/- ##
==========================================
- Coverage 60.87% 60.64% -0.23%
==========================================
Files 73 76 +3
Lines 10150 10216 +66
==========================================
+ Hits 6179 6196 +17
- Misses 3399 3453 +54
+ Partials 572 567 -5
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
I think the part I like about this the most is that, by default, we are back to there being a sane, Go-friendly default import path for users of the client library:
This is perhaps a bit pedantic, but since the singular makes it sound like they are expecting to operate on a single function, and the name is "Knative Functions", would it be better for the user if the package name were plural?
Overall huge improvement. Yes' let's merge quickly to minimize collateral damage. /lgtm |
Signed-off-by: Zbynek Roubalik <zroubalik@gmail.com>
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lkingland, zroubalik The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Zbynek Roubalik <zroubalik@gmail.com>
Signed-off-by: Zbynek Roubalik <zroubalik@gmail.com>
* add option 'branch' to command 'repository add' * Format go code (#1407) Signed-off-by: Knative Automation <automation@knative.team> * chore: refactor repository layout (#1554) Signed-off-by: Zbynek Roubalik <zroubalik@gmail.com> * fixup: removes --branch tag from repo commands Removes the currently in-flight work on the `--branch` tag, simply supporting a `refspec` on the repository URI. For example, https://github.com/knative-sandbox/func-tastic#metacontroller will pull the `func-tastic` repo, and set the currently active HEAD to the `metacontroller` branch. Adds support for displaying this with the command `func repo list -v`. Signed-off-by: Lance Ball <lball@redhat.com> * fixup: add example to `func repo add` documentation Signed-off-by: Lance Ball <lball@redhat.com> * fixup: adjust test output expectations Signed-off-by: Lance Ball <lball@redhat.com> --------- Signed-off-by: Knative Automation <automation@knative.team> Signed-off-by: Zbynek Roubalik <zroubalik@gmail.com> Signed-off-by: Lance Ball <lball@redhat.com> Co-authored-by: Yingchun Guo <yingchun.guo@intel.com> Co-authored-by: knative-automation <automation@knative.team> Co-authored-by: Zbynek Roubalik <zroubalik@gmail.com>
Signed-off-by: Zbynek Roubalik zroubalik@gmail.com
I'd prefer if we can merge this PR asap, rebasing this will be very painful :))
Moved majority of code into
pkg
. This is the layout now:Changes
Fixes: #1547