feat(templates): remove liveness and readiness from defaults

[lance]

Changes

The liveness and readiness URLs are defined in code as defaulting to /health/liveness and /health/readiness respectively. The deploy command handles these defaults without requiring them to exist in the func.yaml file. Existing tests for defaults and overrides already exist, so this change does not require additional tests to be included.

/kind enhancement

Fixes: #1281

Release Note

removes default endpoints from func.yaml to improve file legibility

[codecov]

Codecov Report

Base: 60.28% // Head: 50.85% // Decreases project coverage by -9.43% ⚠️

Coverage data is based on head (87cf62c) compared to base (5a4803b).
Patch has no changes to coverable lines.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1555      +/-   ##
==========================================
- Coverage   60.28%   50.85%   -9.43%     
==========================================
  Files          75       73       -2     
  Lines       10214    10079     -135     
==========================================
- Hits         6157     5126    -1031     
- Misses       3489     4519    +1030     
+ Partials      568      434     -134     

Flag	Coverage Δ
integration-tests	?
unit-tests	?
unit-tests-ubuntu-latest	50.85% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
pkg/functions/repository.go	72.60% <ø> (-0.36%)	⬇️
pkg/k8s/security_context.go	0.00% <0.00%> (-100.00%)	⬇️
pkg/knative/logs.go	0.00% <0.00%> (-80.42%)	⬇️
pkg/k8s/dialer.go	0.00% <0.00%> (-73.44%)	⬇️
pkg/k8s/persistent_volumes.go	0.00% <0.00%> (-72.40%)	⬇️
pkg/k8s/logs.go	0.00% <0.00%> (-70.00%)	⬇️
pkg/knative/describer.go	0.00% <0.00%> (-66.18%)	⬇️
pkg/knative/lister.go	0.00% <0.00%> (-64.92%)	⬇️
pkg/knative/deployer.go	6.16% <0.00%> (-57.35%)	⬇️
pkg/knative/client.go	0.00% <0.00%> (-53.85%)	⬇️
... and 12 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

[lance]

/hold
It seems this is a little naive.

[lance]

/unhold

[lkingland]

If it passes tests, this is precisely what I was hoping would work!

/lgtm
/hold for zbynek's massive refactor to the repo to land first, which was submitted one hour prior

[lance]

@lkingland after rebasing, I need another /lgtm please

[zroubalik]

/lgtm

[knative-prow]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lance, lkingland, zroubalik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [lance,lkingland,zroubalik]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[zroubalik]

/override codecov/project

[knative-prow]

@zroubalik: Overrode contexts on behalf of zroubalik: codecov/project

In response to this:

/override codecov/project

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.