Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix root cmd init #163

Merged
merged 1 commit into from
Oct 8, 2020
Merged

fix: Fix root cmd init #163

merged 1 commit into from
Oct 8, 2020

Conversation

dsimansk
Copy link
Contributor

@dsimansk dsimansk commented Oct 8, 2020

As @matejvasek pointed out I shouldn't change init() and rather benefit from it's intended build-in behaviour in plugin.go, otherwise standalone faas binary is broken.

@dsimansk dsimansk requested a review from a team October 8, 2020 16:07
@dsimansk dsimansk changed the title fix: Fix root cmnd init fix: Fix root cmd init Oct 8, 2020
@matejvasek matejvasek merged commit ec5327d into knative:main Oct 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants