fix: s2i python build on Windows

[matejvasek]

Changes

• 🐛 Fix s2i python build on Windows.

/kind bug

fix: s2i python build on Windows

[knative-prow]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: matejvasek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [matejvasek]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[codecov]

Codecov Report

Patch coverage has no change and project coverage change: -3.67 ⚠️

Comparison is base (7c724bc) 54.79% compared to head (2b7edbc) 51.12%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1641      +/-   ##
==========================================
- Coverage   54.79%   51.12%   -3.67%     
==========================================
  Files          92       92              
  Lines       11909    11913       +4     
==========================================
- Hits         6525     6091     -434     
- Misses       4781     5270     +489     
+ Partials      603      552      -51     

Flag	Coverage Δ
e2e-test-oncluster	?
e2e-test-runtime-go	28.14% <0.00%> (?)
e2e-test-runtime-springboot	28.27% <0.00%> (?)
unit-tests-ubuntu-latest	49.03% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
pkg/builders/s2i/builder.go	61.60% <0.00%> (+0.22%)	⬆️

... and 16 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

[matejvasek]

@jrangelramos does this work?

[matejvasek]

@lance please override the Lint.

[matejvasek]

@lance maybe we have a time to backport this?

[krsna-m]

/override "style / Golang / Lint"

[knative-prow]

@kvmware: Overrode contexts on behalf of kvmware: style / Golang / Lint

In response to this:

/override "style / Golang / Lint"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[lance]

/lgtm

[lance]

/cherry-pick release-1.9

[knative-prow-robot]

@lance: once the present PR merges, I will cherry-pick it on top of release-1.9 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[lance]

Overriding all of the style checks since this is basically a one-liner.

/override "style / suggester / shell"
/override "style / suggester / yaml"
/override "style / suggester / github_actions"

[knative-prow]

@lance: Overrode contexts on behalf of lance: style / suggester / github_actions, style / suggester / shell, style / suggester / yaml

In response to this:

Overriding all of the style checks since this is basically a one-liner.

/override "style / suggester / shell"
/override "style / suggester / yaml"
/override "style / suggester / github_actions"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[jrangelramos]

it works on Windows!

[matejvasek]

I have absolutely on idea why that one test is failing.
It is also failing on unrelated PR. Makes no sense.

[jrangelramos]

It seems to be related to this recent change https://github.com/knative/func/pull/1631/files#diff-12756d69e272b512547442b82be9dee485eff66dbce9705b46c164f2c814b00eL17

I just tried a PR (using new previous actions) to confirm #1642

[lance]

It seems to be related to this recent change https://github.com/knative/func/pull/1631/files#diff-12756d69e272b512547442b82be9dee485eff66dbce9705b46c164f2c814b00eL17

I just tried a PR (using new previous actions) to confirm #1642

Thanks for looking into this @jrangelramos - we should bubble this up to @knative/productivity-leads

[lance]

Even that is confusing though. Going back to the last SHA that had go-test.yaml in the repo, I don't see a real difference.

git co b28ad7ba3ca062ec9bdafa0f7b84cd4dca22a7a4
Previous HEAD position was c739e0b Drop unused matrix strategy and some step ids (#81)
HEAD is now at b28ad7b sync up changes for security workflow (#102)

diff go-test.yaml reusable-go-test.yaml
62c62
<         run: echo 'COVER_OPTS=-coverprofile=coverage.txt -covermode=atomic' >> $GITHUB_ENV
---
>         run: echo 'COVER_OPTS=-coverprofile=coverage.txt -covermode=atomic' >> "$GITHUB_ENV"
65c65
<         run: go test -race $COVER_OPTS ./...
---
>         run: go test -race "$COVER_OPTS ./..."

[matejvasek]

@lance please just override the test

[lance]

/override "test / Unit Tests"

[knative-prow]

@lance: Overrode contexts on behalf of lance: test / Unit Tests

In response to this:

/override "test / Unit Tests"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[knative-prow-robot]

@lance: #1641 failed to apply on top of branch "release-1.9":

Applying: fix: s2i build on Windows
Using index info to reconstruct a base tree...
A	pkg/builders/s2i/builder.go
Falling back to patching base and 3-way merge...
Auto-merging s2i/builder.go
CONFLICT (content): Merge conflict in s2i/builder.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 fix: s2i build on Windows
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-1.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.