Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup Rust cloudevents example #1799

Merged
merged 1 commit into from
Jun 10, 2023
Merged

Cleanup Rust cloudevents example #1799

merged 1 commit into from
Jun 10, 2023

Conversation

saschagrunert
Copy link
Contributor

Changes

  • Using a more opinionated release profile to optimize binary
  • Removing not required dependencies
  • Updating the rest of the dependencies
  • Switch to Rust edition 2021
  • Cleanup imports by importing the concrete types
  • Avoid unnecessary type assertions
  • Do not unwrap port

/kind cleanup

Release Note

Updated Rust cloudevents example.

Docs

None

@knative-prow knative-prow bot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jun 8, 2023
@knative-prow knative-prow bot requested review from nainaz and vyasgun June 8, 2023 09:16
@matejvasek
Copy link
Contributor

When modifying templates the generate/zz_filesystem_generated.go file has to be updated too (make generate/zz_filesystem_generated.go).

@codecov
Copy link

codecov bot commented Jun 8, 2023 •
edited
Loading

Codecov Report

Patch coverage has no change and project coverage change: +1.13 🎉

Comparison is base (0ef55f8) 62.50% compared to head (35364d4) 63.63%.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1799      +/-   ##
==========================================
+ Coverage   62.50%   63.63%   +1.13%     
==========================================
  Files         106      106              
  Lines       13422    13422              
==========================================
+ Hits         8389     8541     +152     
+ Misses       4246     4071     -175     
- Partials      787      810      +23
Flag Coverage Δ
e2e-test 37.69% <ø> (ø)
e2e-test-oncluster 33.39% <ø> (+0.09%) ⬆️
e2e-test-oncluster-runtime 28.59% <ø> (?)
e2e-test-runtime-go 27.32% <ø> (?)
e2e-test-runtime-node 28.39% <ø> (?)
e2e-test-runtime-python 28.39% <ø> (?)
e2e-test-runtime-quarkus 28.52% <ø> (?)
e2e-test-runtime-springboot 27.38% <ø> (?)
e2e-test-runtime-typescript 28.52% <ø> (?)
integration-tests 52.15% <ø> (+3.75%) ⬆️
unit-tests-macos-latest 49.90% <ø> (+0.02%) ⬆️
unit-tests-ubuntu-latest 50.68% <ø> (-0.03%) ⬇️
unit-tests-windows-latest 49.95% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 7 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@saschagrunert saschagrunert force-pushed the rust-events-cleanup branch from 94e1969 to 1ff2ad5 Compare June 9, 2023 06:58
@saschagrunert
Copy link
Contributor Author

Thank you for the hint @matejvasek, updated the generated file.

@matejvasek
Copy link
Contributor

/approve
/lgtm

@knative-prow knative-prow bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jun 9, 2023
@knative-prow-robot knative-prow-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 9, 2023
@saschagrunert
Cleanup Rust cloudevents example
35364d4 
By:

- Using a more opinionated release profile to optimize binary
- Removing not required dependencies
- Updating the rest of the dependencies
- Switch to Rust edition 2021
- Cleanup imports by importing the concrete types
- Avoid unnecessary type assertions
- Do not unwrap port

Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
@saschagrunert saschagrunert force-pushed the rust-events-cleanup branch from 1ff2ad5 to 35364d4 Compare June 9, 2023 18:02
@knative-prow knative-prow bot removed the lgtm Indicates that a PR is ready to be merged. label Jun 9, 2023
@knative-prow-robot knative-prow-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 9, 2023
@saschagrunert
Copy link
Contributor Author

Rebased on top of main.

@matejvasek
Copy link
Contributor

/approve
/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jun 10, 2023
@knative-prow
Copy link

knative-prow bot commented Jun 10, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: matejvasek, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit 529957e into knative:main Jun 10, 2023
@saschagrunert saschagrunert deleted the rust-events-cleanup branch June 12, 2023 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nainaz nainaz Awaiting requested review from nainaz

@vyasgun vyasgun Awaiting requested review from vyasgun

Assignees

@matejvasek matejvasek

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@saschagrunert @matejvasek @knative-prow-robot