Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Update client-go dependency to aligned version #1957

Merged
merged 1 commit into from
Aug 31, 2023
Merged

chore: Update client-go dependency to aligned version #1957

merged 1 commit into from
Aug 31, 2023

Conversation

dsimansk
Copy link
Contributor

Changes

@matejvasek following up on the previous topic on your PR. It seems client-go would newer be bumped because it was stuck in func's go.mod now. IMO it was chain of previous versions from Tekton, that introduced it in a first place.

  • 🧹 chore: Update client-go dependency to aligned version

/kind

Fixes #

Release Note

chore: Update client-go dependency to aligned version

@dsimansk dsimansk requested a review from matejvasek August 30, 2023 16:10
@matejvasek
Copy link
Contributor

/approve
/lgtm

@knative-prow
Copy link

knative-prow bot commented Aug 30, 2023

@dsimansk: The label(s) kind/<kind> cannot be applied, because the repository doesn't have them.

In response to this:

Changes

@matejvasek following up on the previous topic on your PR. It seems client-go would newer be bumped because it was stuck in func's go.mod now. IMO it was chain of previous versions from Tekton, that introduced it in a first place.

  • 🧹 chore: Update client-go dependency to aligned version

/kind

Fixes #

Release Note

chore: Update client-go dependency to aligned version

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow knative-prow bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Aug 30, 2023
@knative-prow knative-prow bot requested review from maximilien and vyasgun August 30, 2023 16:16
@codecov
Copy link

codecov bot commented Aug 30, 2023 •
edited
Loading

Codecov Report

Patch coverage has no change and project coverage change: +1.01% 🎉

Comparison is base (7a7e4bf) 61.73% compared to head (2435bf5) 62.75%.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1957      +/-   ##
==========================================
+ Coverage   61.73%   62.75%   +1.01%     
==========================================
  Files         106      106              
  Lines       13678    13678              
==========================================
+ Hits         8444     8583     +139     
+ Misses       4389     4229     -160     
- Partials      845      866      +21
Flag Coverage Δ
e2e-test 36.12% <ø> (-16.65%) ⬇️
e2e-test-oncluster 30.38% <ø> (ø)
e2e-test-runtime-go 25.62% <ø> (?)
e2e-test-runtime-node 26.63% <ø> (?)
e2e-test-runtime-python 26.63% <ø> (?)
e2e-test-runtime-quarkus 26.74% <ø> (?)
e2e-test-runtime-rust 25.62% <ø> (?)
e2e-test-runtime-springboot 25.76% <ø> (?)
e2e-test-runtime-typescript 26.74% <ø> (?)
integration-tests 51.37% <ø> (?)
unit-tests-macos-latest 48.17% <ø> (?)
unit-tests-ubuntu-latest 48.96% <ø> (ø)
unit-tests-windows-latest 48.20% <ø> (-0.11%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Aug 30, 2023
@dsimansk dsimansk added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Aug 30, 2023
@matejvasek
Copy link
Contributor

/retest-all

@matejvasek
Copy link
Contributor

/retest

@matejvasek
Copy link
Contributor

/help

@matejvasek matejvasek force-pushed the pr/remove-k8s-replace branch from 14b0fb4 to 2435bf5 Compare August 31, 2023 17:34
@knative-prow knative-prow bot removed the lgtm Indicates that a PR is ready to be merged. label Aug 31, 2023
@matejvasek
Copy link
Contributor

/approve
/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Aug 31, 2023
@knative-prow
Copy link

knative-prow bot commented Aug 31, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dsimansk, matejvasek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [dsimansk,matejvasek]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit bcfb83c into knative:main Aug 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matejvasek matejvasek matejvasek approved these changes

@maximilien maximilien Awaiting requested review from maximilien

@vyasgun vyasgun Awaiting requested review from vyasgun

Assignees

@matejvasek matejvasek

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dsimansk @matejvasek