fix: mount of Docker API socket from Docker Desktop

[matejvasek]

• Fixed mountpoint of docker socket for Docker Desktop.

fixes: #2347

fix: buildpack build failure caused by wrong socket mount-point when using Docker Desktop

[matejvasek]

cc @vpsx

[matejvasek]

PTAL @lkingland @gauron99

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.74%. Comparing base (2e7154c) to head (623cff2).

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2350      +/-   ##
==========================================
+ Coverage   59.37%   65.74%   +6.36%     
==========================================
  Files         128      128              
  Lines       14895    11534    -3361     
==========================================
- Hits         8844     7583    -1261     
+ Misses       5163     2997    -2166     
- Partials      888      954      +66     

Flag	Coverage Δ
e2e-test	37.99% <0.00%> (-0.05%)	⬇️
e2e-test-oncluster	31.18% <0.00%> (?)
e2e-test-oncluster-runtime	27.11% <0.00%> (?)
e2e-test-runtime-go	26.01% <0.00%> (?)
e2e-test-runtime-node	27.00% <0.00%> (?)
e2e-test-runtime-python	27.00% <0.00%> (?)
e2e-test-runtime-quarkus	27.10% <0.00%> (?)
e2e-test-runtime-rust	26.11% <0.00%> (?)
e2e-test-runtime-springboot	26.14% <0.00%> (?)
e2e-test-runtime-typescript	27.09% <0.00%> (?)
integration-tests	51.35% <100.00%> (+2.48%)	⬆️
unit-tests	49.30% <100.00%> (?)
unit-tests-macos-latest	?
unit-tests-ubuntu-latest	?
unit-tests-windows-latest	?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[vpsx]

I just tried it; it works for me! (Docker Desktop for Linux; Ubuntu)

(Not sure if worth mentioning, but just in case: DOCKER_HOST does still need to be explicitly set to the Docker Desktop socket for the first part/pulling builder image to work; it does not look at the docker context)

Thanks!!

[dsimansk]

/override "Integration Test (ubuntu-latest)"

[knative-prow]

@dsimansk: Overrode contexts on behalf of dsimansk: Integration Test (ubuntu-latest)

In response to this:

/override "Integration Test (ubuntu-latest)"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[matejvasek]

PTAL @lkingland

[matejvasek]

PTAL @matzew @gauron99

[knative-prow]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gauron99, lkingland, matejvasek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [gauron99,lkingland,matejvasek]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment