Skip to content

WIP: migrate tracing from OpenCensus to OpenTelemetry #15884

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Fedosin
Copy link
Contributor

@Fedosin Fedosin commented May 14, 2025

Fixes #

Proposed Changes

Release Note


@knative-prow knative-prow bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels May 14, 2025
Copy link

knative-prow bot commented May 14, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Fedosin
Once this PR has been reviewed and has the lgtm label, please assign skonto for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot requested review from dprotaso, dsimansk and skonto May 14, 2025 13:36
Copy link

codecov bot commented May 14, 2025

Codecov Report

Attention: Patch coverage is 38.07947% with 187 lines in your changes missing coverage. Please review.

Project coverage is 80.29%. Comparing base (589b6ab) to head (ab84c3b).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
pkg/tracingotel/setup.go 0.00% 80 Missing ⚠️
pkg/tracingotel/otel.go 34.00% 61 Missing and 5 partials ⚠️
pkg/queue/sharedmain/main.go 0.00% 20 Missing ⚠️
pkg/tracingotel/config/tracing.go 79.16% 10 Missing and 5 partials ⚠️
pkg/activator/handler/handler.go 80.00% 3 Missing and 1 partial ⚠️
pkg/queue/sharedmain/handlers.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #15884      +/-   ##
==========================================
- Coverage   80.91%   80.29%   -0.62%     
==========================================
  Files         210      214       +4     
  Lines       16731    17007     +276     
==========================================
+ Hits        13538    13656     +118     
- Misses       2842     2992     +150     
- Partials      351      359       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Fedosin Fedosin force-pushed the tracingotel branch 3 times, most recently from 1dc2a2f to ca7867b Compare May 14, 2025 21:49
@dprotaso
Copy link
Member

/hold

I'm writing a feature track for this migration - should have something next week

@knative-prow knative-prow bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants