Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(nlp): handle deleted audiofile TASK-566 #5612

Merged
merged 1 commit into from
Mar 27, 2025

Conversation

Akuukis
Copy link
Contributor

@Akuukis Akuukis commented Mar 25, 2025

📣 Summary

In NLP, display deleted audiofiles as deleted.

💭 Notes

Used Mantine components and styles as much as possible.

👀 Preview steps

  1. ℹ️ have an account and a project with a audio question type
  2. submit the form with an audio
  3. open NLP from data table
  4. add debug code in sidebarSubmissionMedia.tsx
     +   attachment.download_url = 'http://kalvis.lv/404'
     +   attachment.download_large_url = 'http://kalvis.lv/404'
     +   attachment.download_medium_url = 'http://kalvis.lv/404'
     +   attachment.download_small_url = 'http://kalvis.lv/404'
  5. 🟡 notice the error, like in the "before" screenshot
  6. add debug code in sidebarSubmissionMedia.tsx
     +   attachment.is_deleted = true
  7. 🔴 [on main] as above
  8. 🟢 [on PR] notice the "Deleted", like in the "after" screenshot
Before image
After image

@Akuukis Akuukis self-assigned this Mar 25, 2025
@Akuukis Akuukis marked this pull request as ready for review March 25, 2025 15:24
@Akuukis Akuukis requested a review from magicznyleszek as a code owner March 25, 2025 15:24
@Akuukis Akuukis merged commit a7e5cbc into main Mar 27, 2025
5 checks passed
@Akuukis Akuukis deleted the kalvis/deleted-attachment-in-nlp branch March 27, 2025 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants