Skip to content

kokkos: fix build failng with KOKKOS_DEFAULT=OFF #219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 20, 2022

Conversation

mzuzek
Copy link

@mzuzek mzuzek commented May 26, 2022

Fix build failing on missing kokkos_exec when LINALG_ENABLE_KOKKOS is ON but LINALG_ENABLE_KOKKOS_DEFAULT is OFF

@mzuzek mzuzek requested review from crtrott and mhoemmen May 26, 2022 09:36
@mzuzek mzuzek self-assigned this May 26, 2022
@mhoemmen
Copy link
Contributor

Regarding my comment on PR #220: Do you think the failing test could be fixed straightforwardly for now, even if the fix is not the most efficient? I would rather have slow code for now, than a disabled test.

@mzuzek
Copy link
Author

mzuzek commented May 27, 2022

@mhoemmen

Regarding my comment on PR #220: Do you think the failing test could be fixed straightforwardly for now, even if the fix is not the most efficient? I would rather have slow code for now, than a disabled test.

Yes, please check #220 (comment).

This fix shall just prevent LINALG_ENABLE_KOKKOS_DEFAULT=OFF builds from failing. On #213 I propose to keep this flag enabled, so that we gain more coverage by also testing Kokkos implementations with native tests too (in Kokkos CI jobs).

@crtrott
Copy link
Member

crtrott commented Jun 20, 2022

I checked that if DEFAULT is OFF it still does not replace std::par etc.

@crtrott crtrott merged commit 8c57ebb into kokkos:main Jun 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants